Report event for the cases when probe returned Unknown result

[SergeyKanzhelev]

There are a few cases when the Unknown result can be returned by the probe. For example see: #106682.

It will be useful to expose those in logs and as an event similar to what we do for Warning:

kubernetes/pkg/kubelet/prober/prober.go

Line 115 in 35f3fc5

pb.recordContainerEvent(pod, &container, v1.EventTypeWarning, events.ContainerProbeWarning, "%s probe warning: %s", probeType, output)

What needs to be done:

1. Implement logging and exposing event in case of Unknown probe result somewhere around

   kubernetes/pkg/kubelet/prober/prober.go

   Line 115 in 35f3fc5

   pb.recordContainerEvent(pod, &container, v1.EventTypeWarning, events.ContainerProbeWarning, "%s probe warning: %s", probeType, output)

2. For each instance of probes potentially returning the Unknown result have a test that validates this test case. It may be either e2e test or unit test. You may find an example of e2e test that results in Unknown result from exec probe in one of the links from Liveness Probe with an invalid command doesn't trigger container restarts and ContainersReady remains True  #106682

/sig node
/help wanted
/good-first-issue
/priority backlog

This issue is marked as "good first issue". Before assigning issue to yourself, please make sure you understand the assignment and list cases you will need to cover with tests.

cc @aojea

[k8s-ci-robot]

@SergeyKanzhelev:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

There are a few cases when the Unknown result can be returned by the probe. For example see: #106682.

It will be useful to expose those in logs and as an event similar to what we do for Warning:

kubernetes/pkg/kubelet/prober/prober.go

Line 115 in 35f3fc5

pb.recordContainerEvent(pod, &container, v1.EventTypeWarning, events.ContainerProbeWarning, "%s probe warning: %s", probeType, output)

What needs to be done:

1. Implement logging and exposing event in case of Unknown probe result somewhere around

   kubernetes/pkg/kubelet/prober/prober.go

   Line 115 in 35f3fc5

   pb.recordContainerEvent(pod, &container, v1.EventTypeWarning, events.ContainerProbeWarning, "%s probe warning: %s", probeType, output)

2. For each instance of probes potentially returning the Unknown result have a test that validates this test case. It may be either e2e test or unit test. You may find an example of e2e test that results in Unknown result from exec probe in one of the links from Liveness Probe with an invalid command doesn't trigger container restarts and ContainersReady remains True  #106682

/sig node
/help wanted
/good-first-issue
/priority backlog

This issue is marked as "good first issue". Before assigning issue to yourself, please make sure you understand the assignment and list cases you will need to cover with tests.

cc @aojea

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[VishalPraneeth]

/assign

[apimpalgaonkar]

/assign

[nerdynikhil]

/assign

[apimpalgaonkar]

/assign

[liangyuanpeng]

@apimpalgaonkar @nerdynikhil Hi, seems like @VishalPraneeth is really working for it and created a PR,

• The event message will include the probe type and the unknown status #116030

[abhilasha2418]

/assign

[ashutosh887]

let me work on this issue now please
/assign

[Harsh22222]

/assign

[bishopmate]

/assign

[RANJEETJ06]

let me sove a issue, i am beginner to git please suggest me a easy issue to resolve

[samyakjain10]

Hey everyone. Just saw this issue assigned to multiple people and multiple PRs raised already. Was curious to know if the issue is resolved or is it up for grabs?

[Ashishraj99]

Implement logging and event exposing in the case of an "Unknown" probe result in the kubernetes/pkg/kubelet/prober/prober.go file. This can be done by adding a new line of code similar to the existing line 113:
go
Type This code
(pb.recordContainerEvent(pod, &container, v1.EventTypeUnkown, events.ContainerProbeWarning, "%s probe warning: %s", probeType, output)
However, instead of using the v1.EventTypeWarning constant, you should use a new constant for the "Unknown" event type, such as v1.EventTypeUnknown.

For each instance where probes potentially return an "Unknown" result, you should have a corresponding test case to validate this scenario. These tests can be either end-to-end (e2e) tests or unit tests. Refer to the example of an e2e test that results in an "Unknown" result from an exec probe in the link you provided (Liveness Probe with an invalid command doesn't trigger container restarts and ContainersReady remains True #106682).

[SoorajBharadwaj07]

Hi,I was looking for an Open issue with "Good first use" label. I would like to work on this issue if this is still not fixed

[SoorajBharadwaj07]

/assign

[SahilTiwaricontact9]

ok

[j0shgrant]

/assign