feature(scheduler): implement matchLabelKeys/mismatchLabelKeys in PodAffinity and PodAntiAffinity #116065

sanposhiho · 2023-02-26T04:37:40Z

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

implement matchLabelKeys in PodAffinity and PodAntiAffinity proposed from KEP-3633.

Which issue(s) this PR fixes:

Fixes #112947
Related kubernetes/enhancements#3633

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The matchLabelKeys/mismatchLabelKeys feature is introduced to the hard/soft PodAffinity/PodAntiAffinity.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/3633-matchlabelkeys-to-podaffinity

sanposhiho · 2023-02-26T04:39:54Z

cc @Huang-Wei
FYI @kubernetes/sig-scheduling-misc

🙏

sanposhiho · 2023-02-26T04:47:33Z

/cc @Huang-Wei

k8s-triage-robot · 2023-02-26T05:58:17Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

sanposhiho · 2023-02-26T07:49:26Z

test/e2e/scheduling/predicates.go

@@ -724,6 +727,231 @@ var _ = SIGDescribe("SchedulerPredicates [Serial]", func() {
 		ginkgo.By(fmt.Sprintf("Trying to create another pod(pod5) with hostport %v but hostIP %s on the node which pod4 resides and expect not scheduled", port, hostIP))
 		createHostPortPodOnNode(ctx, f, "pod5", ns, hostIP, port, v1.ProtocolTCP, nodeSelector, false)
 	})
+	ginkgo.Context("PodAffinity/PodAntiAffinity Filtering", func() {


I'm not sure how the feature gate is treated in e2e testing.
Do I need to do something to run this e2e test with feature gate enabled?

An alpha e2e test cannot be verified in regular pre-submit CI. But optionally, you can submit a PR to test-infra/ to have it enabled in a special CI job where the env enables particular alpha feature gates. Ref: kubernetes/test-infra#27862

So for the e2e, it'd be good to paste the PASS result here. And remember to add [Feature:<feature gate name>] [alpha] string here. Ref: #113442.

Thanks. I'll follow that later.

Checked these added e2e tests are passed.

logs

_output/bin/e2e.test --provider=local --ginkgo.focus='MatchLabelKeysInPodAffinity' I0305 22:41:24.228053 8686 e2e.go:117] Starting e2e run "dd1bfd89-3119-4b70-ad44-f046dfd40634" on Ginkgo node 1 Running Suite: Kubernetes e2e suite - /Users/sanposhiho/workspace/kubernetes ============================================================================ Random Seed: 1678023684 - will randomize all specs Will run 4 of 7124 specs SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS Ran 4 of 7124 Specs in 209.431 seconds SUCCESS! -- 4 Passed | 0 Failed | 0 Pending | 7120 Skipped PASS

Remove e2e test. We generally only do them for features that involve more than just scheduler. Integration tests should be enough.

Now, we (unfortunately) freed from the deadline of v1.27, no need to leave this as follow up.
I moved almost all test cases to unit tests, and keep only basic test cases in the integration tests.

cici37 · 2023-02-28T21:14:11Z

/remove-sig api-machinery

Huang-Wei · 2023-03-02T23:48:04Z

@sanposhiho could you please rebase? I will review after the rebase.

sanposhiho · 2023-08-23T13:29:40Z

@deads2k

Oh, and one other question. If I have a required matchLabelKey, how does the first pod get on any node?

Such Pod is handled like this - in short, a required PodAffinity is ignored so that the first Pod lands somewhere.

// This pod may be the first pod in a series that have affinity to themselves. In order
// to not leave such pods in pending state forever, we check that if no other pod
// in the cluster matches the namespace and selector of this pod, the pod matches
// its own terms, and the node has all the requested topologies, then we allow the pod
// to pass the affinity check.

kubernetes/pkg/scheduler/framework/plugins/interpodaffinity/filtering.go

Lines 351 to 355 in fb785f1

// This pod may be the first pod in a series that have affinity to themselves. In order

// to not leave such pods in pending state forever, we check that if no other pod

// in the cluster matches the namespace and selector of this pod, the pod matches

// its own terms, and the node has all the requested topologies, then we allow the pod

// to pass the affinity check.

sanposhiho · 2023-09-24T07:25:37Z

@deads2k Please retake a look.

pkg/registry/core/pod/strategy.go

deads2k · 2023-10-11T21:24:32Z

pkg/apis/core/validation/validation.go

+		}
+		for _, matchExpression := range labelSelector.MatchExpressions {
+			key := matchExpression.Key
+			if i, ok := labelKeysMap[key]; ok && labelSelectorKeys.Has(key) {


My memory of labelSelector validation is that the .MatchLabels and .MatchExpressions are managed independently. so you can have a labelSelector with MatchLabels and MatchExpressions that check different labels. See https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/validation/validation.go#L56-L66

Does something force sameness inside of affinity terms?

Yes, we're using the same validation function to validate the selector in affinity actually.

kubernetes/pkg/apis/core/validation/validation.go

Line 7592 in da12d7a

allErrs = append(allErrs, unversionedvalidation.ValidateLabelSelector(podAffinityTerm.LabelSelector, labelSelectorValidationOptions, fldPath.Child("labelSelector"))...)

deads2k · 2023-10-11T21:34:00Z

The implementation is creative, but given the immutability of PodAffinity and PodAntiAffinity on pod update, I think it is acceptable. Please add a comment indicating that changes to immutability of PodAffinity and PodAntiAffinity require determining how to reconcile this implementation: this area looks about right https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/validation/validation.go#L4894.

Some confirmation of scheduler behavior and whether validation covers all cases requested.

sanposhiho · 2023-10-12T15:45:08Z

@deads2k I put the comment as suggested. PTAL again.

deads2k · 2023-10-16T18:56:12Z

API looks good

/lgtm
/approve

k8s-ci-robot · 2023-10-16T18:56:19Z

LGTM label has been added.

Git tree hash: 147b0819b8afda3ae0d08837342ee902c4c9d937

k8s-ci-robot · 2023-10-16T18:56:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~api/OWNERS~~ [deads2k]
~~pkg/api/OWNERS~~ [deads2k]
~~pkg/apis/OWNERS~~ [deads2k]
~~pkg/features/OWNERS~~ [deads2k]
~~pkg/generated/openapi/OWNERS~~ [deads2k]
~~pkg/registry/OWNERS~~ [deads2k]
~~staging/src/k8s.io/api/OWNERS~~ [deads2k]
~~staging/src/k8s.io/client-go/applyconfigurations/OWNERS~~ [deads2k]
~~test/integration/scheduler/OWNERS~~ [deads2k,sanposhiho]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deads2k · 2023-10-16T18:57:04Z

/hold

hold in case the sig wants another look

Huang-Wei

some nits. LGTM otherwise.

test/integration/scheduler/filters/filters_test.go

test/integration/scheduler/scoring/priorities_test.go

pkg/registry/core/pod/strategy_test.go

pkg/features/kube_features.go

pkg/apis/core/types.go

sanposhiho · 2023-10-18T10:59:02Z

@Huang-Wei @deads2k Thanks for reviewing. I addressed the comments from @Huang-Wei + squash + rebase.

…tiAffinity

Huang-Wei · 2023-10-18T16:59:54Z

/retest

deads2k · 2023-10-23T14:17:41Z

/hold cancel
/lgtm

k8s-ci-robot · 2023-10-23T14:17:50Z

LGTM label has been added.

Git tree hash: 7ed50cc0444eb32f6fe6a9ec5b153686704d9d67

k8s-ci-robot requested review from chendave and cici37 February 26, 2023 04:38

k8s-ci-robot requested a review from Huang-Wei February 26, 2023 04:47

sanposhiho force-pushed the match-label-key-alternative branch from e4cafa9 to 0af786e Compare February 26, 2023 05:29

sanposhiho force-pushed the match-label-key-alternative branch from 0af786e to 4cce848 Compare February 26, 2023 07:33

sanposhiho commented Feb 26, 2023

View reviewed changes

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Feb 28, 2023

sanposhiho force-pushed the match-label-key-alternative branch from 4cce848 to 6b251ce Compare March 3, 2023 02:04

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2023

sanposhiho force-pushed the match-label-key-alternative branch from ef180ed to beaf1ee Compare August 23, 2023 14:06

deads2k reviewed Oct 11, 2023

View reviewed changes

pkg/registry/core/pod/strategy.go Show resolved Hide resolved

deads2k reviewed Oct 11, 2023

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2023

Huang-Wei reviewed Oct 16, 2023

View reviewed changes

sanposhiho force-pushed the match-label-key-alternative branch from d054d7a to 3923e77 Compare October 18, 2023 10:58

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023

k8s-ci-robot requested review from alculquicondor and deads2k October 18, 2023 10:58

feature(scheduler): implement matchLabelKeys in PodAffinity and PodAn…

d5d3c26

…tiAffinity

sanposhiho force-pushed the match-label-key-alternative branch from 3923e77 to d5d3c26 Compare October 18, 2023 11:28

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 23, 2023

k8s-ci-robot merged commit 581552e into kubernetes:master Oct 23, 2023
15 of 16 checks passed

k8s-ci-robot added this to the v1.29 milestone Oct 23, 2023

sanposhiho changed the title ~~feature(scheduler): implement matchLabelKeys in PodAffinity and PodAntiAffinity~~ feature(scheduler): implement matchLabelKeys/mismatchLabelKeys in PodAffinity and PodAntiAffinity Oct 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature(scheduler): implement matchLabelKeys/mismatchLabelKeys in PodAffinity and PodAntiAffinity #116065

feature(scheduler): implement matchLabelKeys/mismatchLabelKeys in PodAffinity and PodAntiAffinity #116065

sanposhiho commented Feb 26, 2023 •

edited

sanposhiho commented Feb 26, 2023

sanposhiho commented Feb 26, 2023

k8s-triage-robot commented Feb 26, 2023

sanposhiho Feb 26, 2023

Huang-Wei Mar 2, 2023

sanposhiho Mar 3, 2023

sanposhiho Mar 5, 2023 •

edited

alculquicondor Mar 14, 2023

sanposhiho Mar 30, 2023

cici37 commented Feb 28, 2023

Huang-Wei commented Mar 2, 2023

sanposhiho commented Aug 23, 2023

sanposhiho commented Sep 24, 2023

deads2k Oct 11, 2023

sanposhiho Oct 12, 2023 •

edited

deads2k commented Oct 11, 2023

sanposhiho commented Oct 12, 2023

deads2k commented Oct 16, 2023

k8s-ci-robot commented Oct 16, 2023

k8s-ci-robot commented Oct 16, 2023

deads2k commented Oct 16, 2023

Huang-Wei left a comment

sanposhiho commented Oct 18, 2023

Huang-Wei commented Oct 18, 2023

deads2k commented Oct 23, 2023

k8s-ci-robot commented Oct 23, 2023

feature(scheduler): implement matchLabelKeys/mismatchLabelKeys in PodAffinity and PodAntiAffinity #116065

feature(scheduler): implement matchLabelKeys/mismatchLabelKeys in PodAffinity and PodAntiAffinity #116065

Conversation

sanposhiho commented Feb 26, 2023 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

sanposhiho commented Feb 26, 2023

sanposhiho commented Feb 26, 2023

k8s-triage-robot commented Feb 26, 2023

sanposhiho Feb 26, 2023

Choose a reason for hiding this comment

Huang-Wei Mar 2, 2023

Choose a reason for hiding this comment

sanposhiho Mar 3, 2023

Choose a reason for hiding this comment

sanposhiho Mar 5, 2023 • edited

Choose a reason for hiding this comment

alculquicondor Mar 14, 2023

Choose a reason for hiding this comment

sanposhiho Mar 30, 2023

Choose a reason for hiding this comment

cici37 commented Feb 28, 2023

Huang-Wei commented Mar 2, 2023

sanposhiho commented Aug 23, 2023

sanposhiho commented Sep 24, 2023

deads2k Oct 11, 2023

Choose a reason for hiding this comment

sanposhiho Oct 12, 2023 • edited

Choose a reason for hiding this comment

deads2k commented Oct 11, 2023

sanposhiho commented Oct 12, 2023

deads2k commented Oct 16, 2023

k8s-ci-robot commented Oct 16, 2023

k8s-ci-robot commented Oct 16, 2023

deads2k commented Oct 16, 2023

Huang-Wei left a comment

Choose a reason for hiding this comment

sanposhiho commented Oct 18, 2023

Huang-Wei commented Oct 18, 2023

deads2k commented Oct 23, 2023

k8s-ci-robot commented Oct 23, 2023

sanposhiho commented Feb 26, 2023 •

edited

sanposhiho Mar 5, 2023 •

edited

sanposhiho Oct 12, 2023 •

edited