Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce MatchLabelKeys to Pod Affinity and Pod Anti Affinity #3633

Open
9 of 12 tasks
sanposhiho opened this issue Oct 20, 2022 · 88 comments
Open
9 of 12 tasks

Introduce MatchLabelKeys to Pod Affinity and Pod Anti Affinity #3633

sanposhiho opened this issue Oct 20, 2022 · 88 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@sanposhiho
Copy link
Member

sanposhiho commented Oct 20, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig scheduling
/assign

@sanposhiho
Copy link
Member Author

@kubernetes/sig-scheduling-leads Do you think we can work on it this release? Or should postpone until the next release?

@Huang-Wei
Copy link
Member

I took a review and I think we can include it in 1.27.

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 11, 2023
@sanposhiho
Copy link
Member Author

@Huang-Wei Thanks! I'll take a look and modify KEP this weekend.
Do we need to add the milestone to track this issue as a v1.27 feature? If so, could you? (I don't have permission to add milestone on it.)
https://github.com/kubernetes/enhancements/milestone/29

@sanposhiho
Copy link
Member Author

/milestone v1.27

@k8s-ci-robot
Copy link
Contributor

@sanposhiho: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahg-g
Copy link
Member

ahg-g commented Jan 12, 2023

/milestone v1.27

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 12, 2023
@ahg-g
Copy link
Member

ahg-g commented Jan 23, 2023

/stage alpha
/milestone v1.27
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 23, 2023
@marosset
Copy link
Contributor

Hello @sanposhiho 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, it looks like once #3651 merges all the above requirements will be met.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well.
Thank you!

@sanposhiho
Copy link
Member Author

Hi @marosset, #3651 just got merged.

@marosset marosset moved this from At Risk to Tracked in 1.27 Enhancements Tracking Jan 31, 2023
@marosset
Copy link
Contributor

Hi @sanposhiho - With #3651 merged this enhancement is now tracked for now inclusion in the v1.27 release.

Thanks!

/label tracked/yes

@marosset
Copy link
Contributor

marosset commented Mar 8, 2023

Hi @sanposhiho 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

@marosset
Copy link
Contributor

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear
/remove-label tracked/yes
/label tracked/no

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot removed this from the v1.27 milestone Mar 15, 2023
@k8s-ci-robot k8s-ci-robot removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 15, 2023
@marosset marosset moved this from Tracked to Removed From Milestone in 1.27 Enhancements Tracking Mar 15, 2023
@ahg-g
Copy link
Member

ahg-g commented Apr 14, 2023

One use case for this: kubernetes-sigs/jobset#27

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2024
@sanposhiho
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2024
@sanposhiho
Copy link
Member Author

@alculquicondor Can we get a lead-opted-in tag on it for GA? We graduated it to beta at v1.31, and it'll have been two releases at v1.33.

@alculquicondor
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Dec 16, 2024
@dipesh-rawat
Copy link
Member

Hello @sanposhiho 👋, 1.33 Enhancements Lead here.

It looks like this enhancement will be worked on as part of v1.33, so I’ve set the milestone accordingly. If this isn’t accurate, please let me know!

/milestone v1.33

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.31, v1.33 Jan 13, 2025
@dipesh-rawat dipesh-rawat removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 14, 2025
@lzung
Copy link

lzung commented Feb 2, 2025

Hello @sanposhiho 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage stable for v1.33 (correct me, if otherwise)
/stage stable

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v.133. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as Tracked for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Notes:

  • Please update the issue description with the stable stage up to date for easier tracking.
  • Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)? is repeated twice in the KEP.
  • status should be marked as implementable until stable work has been merged and the feature gates are removed. Please update to implementable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Feb 2, 2025
@lzung lzung moved this to Tracked for enhancements freeze in 1.33 Enhancements Tracking Feb 2, 2025
@sanposhiho
Copy link
Member Author

Thanks @lzung, I'll make a follow up PR for those fixes.

@dipesh-rawat dipesh-rawat added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 4, 2025
@michellengnx
Copy link

Hello @sanposhiho 👋, v1.33 Docs Shadow here.
Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?
If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@sanposhiho
Copy link
Member Author

Opened kubernetes/website#49926.

@rytswd
Copy link
Member

rytswd commented Feb 28, 2025

Hi @sanposhiho 👋 -- this is Ryota (@rytswd) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@sanposhiho
Copy link
Member Author

We don't need a blog post for this feature in this release because we already have written the one at the beta release.

@rytswd
Copy link
Member

rytswd commented Feb 28, 2025

@sanposhiho Ah apologies for not taking that into account! Noted, thanks for the clarification!

@lzung
Copy link

lzung commented Mar 4, 2025

Hey again @sanposhiho 👋, 1.33 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025. .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PR needs to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Additionally, please let me know if there are any other PRs in k/k not listed above that we should track for this KEP, so that we can maintain accurate status.

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

@lzung lzung moved this from Tracked for enhancements freeze to At risk for code freeze in 1.33 Enhancements Tracking Mar 4, 2025
@dipesh-rawat
Copy link
Member

Hi @sanposhiho 👋, v1.33 Enhancements team here,

Just a quick friendly reminder as we approach the code freeze later this week, at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

The current status of this enhancement is marked as At risk for code freeze. There are a few requirements mentioned in the comment #3633 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Removed From Milestone
Status: Removed from Milestone
Status: Tracked for Code Freeze
Status: Removed from Milestone
Status: At risk for code freeze
Status: Backlog
Status: Tracked for Doc Freeze
Development

No branches or pull requests