Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce MatchLabelKeys to Pod Affinity and Pod Anti Affinity #3633

Open
2 of 4 tasks
sanposhiho opened this issue Oct 20, 2022 · 58 comments
Open
2 of 4 tasks

Introduce MatchLabelKeys to Pod Affinity and Pod Anti Affinity #3633

sanposhiho opened this issue Oct 20, 2022 · 58 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Milestone

Comments

@sanposhiho
Copy link
Member

sanposhiho commented Oct 20, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig scheduling
/assign

@sanposhiho
Copy link
Member Author

@kubernetes/sig-scheduling-leads Do you think we can work on it this release? Or should postpone until the next release?

@Huang-Wei
Copy link
Member

I took a review and I think we can include it in 1.27.

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 11, 2023
@sanposhiho
Copy link
Member Author

@Huang-Wei Thanks! I'll take a look and modify KEP this weekend.
Do we need to add the milestone to track this issue as a v1.27 feature? If so, could you? (I don't have permission to add milestone on it.)
https://github.com/kubernetes/enhancements/milestone/29

@sanposhiho
Copy link
Member Author

/milestone v1.27

@k8s-ci-robot
Copy link
Contributor

@sanposhiho: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahg-g
Copy link
Member

ahg-g commented Jan 12, 2023

/milestone v1.27

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 12, 2023
@ahg-g
Copy link
Member

ahg-g commented Jan 23, 2023

/stage alpha
/milestone v1.27
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 23, 2023
@marosset
Copy link
Contributor

Hello @sanposhiho 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, it looks like once #3651 merges all the above requirements will be met.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well.
Thank you!

@sanposhiho
Copy link
Member Author

Hi @marosset, #3651 just got merged.

@marosset
Copy link
Contributor

Hi @sanposhiho - With #3651 merged this enhancement is now tracked for now inclusion in the v1.27 release.

Thanks!

/label tracked/yes

@marosset
Copy link
Contributor

marosset commented Mar 8, 2023

Hi @sanposhiho 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

@marosset
Copy link
Contributor

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear
/remove-label tracked/yes
/label tracked/no

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot removed this from the v1.27 milestone Mar 15, 2023
@k8s-ci-robot k8s-ci-robot removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 15, 2023
@ahg-g
Copy link
Member

ahg-g commented Apr 14, 2023

One use case for this: kubernetes-sigs/jobset#27

@sanposhiho
Copy link
Member Author

@ahg-g Could you add /milestone v1.28 on it?
I'm planning to continue working on it in v1.28.

@ahg-g
Copy link
Member

ahg-g commented Apr 16, 2023

/stage alpha
/milestone v1.28
/label lead-opted-in

@Princesso
Copy link

Hi @sanposhiho! The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

@alculquicondor
Copy link
Member

kubernetes/website#39779 it should be that one

@Princesso
Copy link

@alculquicondor, the PR is closed. Could you or @sanposhiho kindly open another one against dev-1.29 for this release cycle? Thanks

@Huang-Wei
Copy link
Member

cc @sanposhiho

@alculquicondor
Copy link
Member

Created one kubernetes/website#43566

@sanposhiho
Copy link
Member Author

@Princesso Sorry, I missed your last reminder. Thanks @alculquicondor for creating that.

@kcmartin
Copy link

Hi @sanposhiho! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

@sanposhiho
Copy link
Member Author

@kcmartin

I don't think this enhancement is big enough to write a blog post, at least during the alpha stage. Maybe we'll want to have one in beta, but let us skip the blog post for this release.

@AnaMMedina21
Copy link

AnaMMedina21 commented Oct 30, 2023

Hello @sanposhiho 👋, v1.29 Enhancements team here.

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Please update KEP Link to https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/3633-matchlabelkeys-to-podaffinity, add any Docs link such as kubernetes/website#43566 and ensure they are approved.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

With all this, the status of this KEP is At Risk for Code Freeze.

As always, we are here to help if any questions come up. Thanks!

@sanposhiho
Copy link
Member Author

sanposhiho commented Oct 30, 2023

@AnaMMedina21 We already merged the PR necessary for this enhancement.
kubernetes/kubernetes#116065 is the only one.

@AnaMMedina21
Copy link

@sanposhiho In the Issue Description can you update the KEP link to the latest link? The link broke when it got renamed from matchlabelselectors
and this KEP will be Tracked for Code Freeze when kubernetes/kubernetes#116065 is approved

@npolshakova
Copy link

Hello @sanposhiho 👋, 1.29 Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description, this enhancement is now marked as tracked for code freeze for the 1.29 Code Freeze! 🚀

The test freeze is 01:00 UTC Wednesday 15th November 2023 / 18:00 PDT Tuesday 14th November 2023. Please make sure all test PRs are merged in by then. Let me know if there are any test PRs we should track. Thanks!

@kevarr
Copy link

kevarr commented Jan 4, 2024

@sanposhiho is there a similar enhancement planned to add MatchLabelKeys/mismatchLabelKeys to the PodDisruptionBudgetSpec as well?

@alculquicondor
Copy link
Member

That doesn't sound possible, as there is no Pod to get the keys from.

@sanposhiho
Copy link
Member Author

@kubernetes/sig-scheduling-leads Can we make it beta in this release? If Yes, can anyone /label lead-opted-in?

@Huang-Wei
Copy link
Member

/label lead-opted-in

@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
Shall we add /milestone v1.30? Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Jan 16, 2024
@salehsedghpour
Copy link
Contributor

salehsedghpour commented Jan 21, 2024

Hello @sanposhiho 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Update the README.md file with the latest template. There is a new question in Scalability part in Production Readiness Review Questionnaire that does not exist. Moreover, all questions in the PRR questionnaire need to be answered.
  • The latest-milestone and stage should be updated to 1.30 and beta in the kep.yaml file respectively.
  • The production readiness review should be completed and updated with the information for the targeting stage beta.
  • Make sure the milestone is updated to v1.30 using /milestone v1.30 command.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well, I couldn't find any related PR regarding this KEP in k/enhancements. Thank you!

@sanposhiho
Copy link
Member Author

Shall we add /milestone v1.30? Thanks!

@Huang-Wei can you? 🙏

@Huang-Wei
Copy link
Member

/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 28, 2024
@salehsedghpour
Copy link
Contributor

With #4450 being merged, this Enhancements can now be marked as tracked for enhancements freeze

@natalisucks
Copy link

Hi @sanposhiho,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

@Vyom-Yadav
Copy link
Member

Hello @sanposhiho 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!


I see this being promoted to beta in v1.30. Please update the issue description to reflect the beta changes and ✔️ the alpha changes section. I don't see any PR in the docs website linking to this issue (in issue activity history), so marking this as "Need Docs". At minimum, we'll need a feature bump docs PR (If there are no logical changes). Thanks!

@sanposhiho
Copy link
Member Author

sanposhiho commented Feb 17, 2024

@natalisucks
I'll write the blog post for this release.
kubernetes/website#45182

@Vyom-Yadav
Here it is: kubernetes/website#45181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
Status: Removed From Milestone
Status: Removed from Milestone
Status: Tracked for Code Freeze
Status: Tracked for Enhancements Freeze
Status: Backlog
Development

No branches or pull requests