Introduce MatchLabelKeys to Pod Affinity and Pod Anti Affinity

[sanposhiho]

Enhancement Description

• One-line enhancement description (can be used as a release note): Introduce MatchLabelKeys to Pod Affinity and Pod Anti Affinity
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/3633-matchlabelkeys-to-podaffinity
• Discussion Link: Introduce MatchLabelKeys (the same one as Pod Topology Spread) to PodAffinityTerm kubernetes#112947
• Primary contact (assignee): @sanposhiho
• Responsible SIGs: sig/scheduling
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): v1.29
  • Beta release target (x.y): v1.30
  • Stable release target (x.y): v1.32
• Alpha
  • KEP (k/enhancements) update PR(s):
    • 1.27 KEP-3633: Introduce MatchLabelKeys to PodAffinity and PodAntiAffinity #3651
    • fix(kep-3633): redesign matchLabelSelectors as matchLabelKeys + mismatchLabelKeys #4069
  • Code (k/k) update PR(s):　
    • feature(scheduler): implement matchLabelKeys/mismatchLabelKeys in PodAffinity and PodAntiAffinity kubernetes#116065
  • Docs (k/website) update PR(s):
    • add: the doc for matchLabelKeys/mismatchLabelKeys in pod (anti)affinity website#43812
• Beta
  • KEP (k/enhancements) update PR(s):
    • 1.30 KEP-3633: graduate matchLabelKeys/mismatchLabelKeys to beta #4450
    • 1.31 Graduate MatchLabelKeys to beta in v1.31 #4627
  • Code (k/k) update PR(s):
    • 1.29 feature(scheduler): implement matchLabelKeys/mismatchLabelKeys in PodAffinity and PodAntiAffinity kubernetes#116065
    • 1.31 graduate MatchLabelKeysInPodAffinity to Beta kubernetes#123638
  • Docs (k/website) update(s):
    • graduate MatchLabelKeysInPodAffinity to beta website#45181
    • blog post for MatchLabelKeys in PodAffinity website#46833

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig scheduling
/assign

[sanposhiho]

@kubernetes/sig-scheduling-leads Do you think we can work on it this release? Or should postpone until the next release?

[Huang-Wei]

I took a review and I think we can include it in 1.27.

/label lead-opted-in

[sanposhiho]

@Huang-Wei Thanks! I'll take a look and modify KEP this weekend.
Do we need to add the milestone to track this issue as a v1.27 feature? If so, could you? (I don't have permission to add milestone on it.)
https://github.com/kubernetes/enhancements/milestone/29

[sanposhiho]

/milestone v1.27

[k8s-ci-robot]

@sanposhiho: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ahg-g]

/milestone v1.27

[ahg-g]

/stage alpha
/milestone v1.27
/label lead-opted-in

[marosset]

Hello @sanposhiho 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.27
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, it looks like once #3651 merges all the above requirements will be met.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well.
Thank you!

[sanposhiho]

Hi @marosset, #3651 just got merged.

[marosset]

Hi @sanposhiho - With #3651 merged this enhancement is now tracked for now inclusion in the v1.27 release.

Thanks!

/label tracked/yes

[marosset]

Hi @sanposhiho 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

• feature(scheduler): implement matchLabelKeys/mismatchLabelKeys in PodAffinity and PodAntiAffinity kubernetes#116065

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

[marosset]

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear
/remove-label tracked/yes
/label tracked/no

[ahg-g]

One use case for this: kubernetes-sigs/jobset#27

[sanposhiho]

@ahg-g Could you add /milestone v1.28 on it?
I'm planning to continue working on it in v1.28.

[ahg-g]

/stage alpha
/milestone v1.28
/label lead-opted-in

[salehsedghpour]

With #4450 being merged, this Enhancements can now be marked as tracked for enhancements freeze

[natalisucks]

Hi @sanposhiho,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

[Vyom-Yadav]

Hello @sanposhiho 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

---

I see this being promoted to beta in v1.30. Please update the issue description to reflect the beta changes and ✔️ the alpha changes section. I don't see any PR in the docs website linking to this issue (in issue activity history), so marking this as "Need Docs". At minimum, we'll need a feature bump docs PR (If there are no logical changes). Thanks!

[sanposhiho]

@natalisucks
I'll write the blog post for this release.
kubernetes/website#45182

@Vyom-Yadav
Here it is: kubernetes/website#45181

[salehsedghpour]

Hey again @sanposhiho 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, I couldn't find any (open) PRs in k/k. With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[sanposhiho]

@salehsedghpour

Please let me know if there are other PRs in k/k we should be tracking for this KEP.

kubernetes/kubernetes#123638 is the only one necessary for this beta graduation, thanks.

[salehsedghpour]

Hello @sanposhiho 👋 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.30 milestone.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

/milestone clear

[sanposhiho]

@kubernetes/sig-scheduling-leads
Can anyone add /label lead-opted-in, I'll work on this in the next release cycle too. We're just waiting for the api-reviews in -
kubernetes/kubernetes#123638

[Huang-Wei]

/label lead-opted-in

[alculquicondor]

/milestone v1.31

[tjons]

Hello @sanposhiho 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage beta for 1.31 (correct me, if otherwise)

Here’s where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: { 1.31 }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria.
• KEP has submitted a production readiness review request for approval and has a reviewer assigned.
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[sreeram-venkitesh]

/stage beta

[salaxander]

Hello @sanposhiho 👋, 1.31 Docs Shadow here.

Does the work for the KEP planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

[sanposhiho]

@salaxander Opened in -
kubernetes/website#45181

[mbianchidev]

Hey @sanposhiho

👋 from the v1.31 Communications Team!
We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[sanposhiho]

@mbianchidev

Created an placeholder PR in -
kubernetes/website#46833

[mbianchidev]

@mbianchidev

Created an placeholder PR in - kubernetes/website#46833

Amazing! Let me know if you need anything now or later on :)

[tjons]

Hey again @sanposhiho 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024 .

I found one PR for this KEP in 1.31:

• graduate MatchLabelKeysInPodAffinity to Beta kubernetes#123638

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

With the above criteria met, this enhancement is now tracked for code freeze!

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[sanposhiho]

Thanks, you're right, that's the only one we need for this enhancement.