Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ContainerStatus.ResourcesAllocated to ContainerStatus.AllocatedResources #116450

Merged
merged 3 commits into from Mar 12, 2023
Merged

Rename ContainerStatus.ResourcesAllocated to ContainerStatus.AllocatedResources #116450

merged 3 commits into from Mar 12, 2023

Conversation

vinaykul
Copy link
Contributor

@vinaykul vinaykul commented Mar 10, 2023 •
edited

What type of PR is this?

/kind cleanup
/kind api-change

What this PR does / why we need it:

Renaming ContainerStatus.ResourcesAllocated to ContainerStatus.AllocatedResources makes it consistent with PVCStatus.AllocatedResouces without change of meaning for in-place pod resize.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation area/kubelet area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 10, 2023
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@vinaykul
Copy link
Contributor Author

/assign @thockin

@vinaykul vinaykul force-pushed the restart-free-pod-vertical-scaling-api branch from ce24b1b to 2eb2a80 Compare March 10, 2023 15:12
@vinaykul
Copy link
Contributor Author

/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2
/test pull-kubernetes-e2e-gce-cos-alpha-features

@vinaykul vinaykul force-pushed the restart-free-pod-vertical-scaling-api branch from 2eb2a80 to d011cc4 Compare March 10, 2023 15:35
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 10, 2023
@vinaykul
Copy link
Contributor Author

/skip

@vinaykul
Copy link
Contributor Author

/assign @harshanarayana @palnabarun @dims @cici37

Please review CHANGELOG fix

@vinaykul
Copy link
Contributor Author

/assign @rjsadow

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Needs Approver in SIG Node PR Triage Mar 10, 2023
@jeremyrickard
Copy link
Contributor

@vinaykul does this need a release note?

@vinaykul
Copy link
Contributor Author

@vinaykul does this need a release note?

This particular PR? no.
The main PR #102884 this is updating based on an API review discussion last night does need release note, and has placeholder PRs for blog and docs as well.

@vinaykul
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 10, 2023
@vinaykul vinaykul mentioned this pull request Mar 11, 2023
Open
26 tasks
justaugustus
justaugustus approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

SIG Node CI/Test Board automation moved this from Triage to PRs - Needs Approver Mar 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, thockin, vinaykul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3c6e419 into kubernetes:master Mar 12, 2023
SIG Node CI/Test Board automation moved this from PRs - Needs Approver to Done Mar 12, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Mar 12, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 12, 2023
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Mar 13, 2023
Closed
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 14, 2023
@vinaykul vinaykul mentioned this pull request May 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@justaugustus justaugustus justaugustus approved these changes

@bobbypage bobbypage Awaiting requested review from bobbypage

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@dims dims

@justaugustus justaugustus

@harshanarayana harshanarayana

@thockin thockin

@cici37 cici37

@palnabarun palnabarun

@rjsadow rjsadow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubelet area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet