-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-Place Update of Pod Resources #1287
Comments
/assign @vinaykul |
👋 Hey there @vinaykul. I'm a shadow on the 1.17 Release Team, working on Enhancements. We're tracking issues for the 1.17 release and I wanted to reach out and ask we should track this (or more specifically I guess the In-Place Update of Pod Resources feature) for 1.17? The current release schedule is: Monday, September 23 - Release Cycle Begins We're only 5 days away from the Enhancements Freeze, so if you intend to graduate this capability in the 1.17 release, here are the requirements that you'll need to satisfy:
Thanks @vinaykul |
Hi @jeremyrickard I'll do my best to get this KEP to implementable state by next Tuesday, but it looks like a stretch at this point - the major item is to complete API review with @thockin , and that depends on his availability. The actual code changes are not that big. Nevertheless, the safe option would be to track this for 1.18.0 release, I'll update you by next Monday. |
@jeremyrickard @mrbobbytables This KEP will take some more discussion - key thing is API review. It does not look like @thockin or another API reviewer is available soon. Could we please track this KEP for v1.18? |
/milestone v1.18 |
@PatrickLang Here's a first stab at the proposed CRI change to allow UpdateContainerResources to work with Windows. Please take a look.. let's discuss in tomorrow's sig meeting
|
@vinaykul It looks like since the above PR was merged, this was removed from the API review queue. I believe you need to open a new PR that moves the state to implementable, and then add the API-review label to get it back in the queue and get a reviewer. Edit: you should also include any other changes (e.g. windows CRI changes) required to move the feature to implementable in the PR as well. |
@dashpole Thanks! I've started a provisional mini-KEP per our discussion last week for the CRI changes (Dawn mentioned last week that we should take that up separately). imho the CRI changes does not block the implementation of this KEP, as it is between Kubelet and runtime, and user is not affected by it. In a second commit to the same PR, I've addressed another key issue (update api failure handling), and requested change to move primary KEP to implementable. With this, everything is in one place, and we can use it for API review. |
Hey there @vinaykul -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.18? The current release schedule is:
To be included in the release,
If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍 We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements Thanks! :) |
@palnabarun Yes, I'm planning to work towards alpha code targets for this feature in 1.18. I've updated the KEP adding test plan and graduation criteria sections that I will be reviewing with SIG-Node this week and hope to get it implementable before Jan 28. I'll update this thread if anything changes. |
Thank you @vinaykul for the updates. :) |
/stage alpha |
/milestone v1.18 |
Just a reminder since the blog opt-in deadline is so close! |
Blog placeholder: kubernetes/website#48576 |
Hey again @tallclair 👋 v1.32 Enhancements team here, Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 . Here's where this enhancement currently stands:
For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):
Additionally, please let me know if there are any other PRs in k/k not listed in the description or not linked with this GitHub issue that we should track for this KEP, so that we can maintain accurate status. The status of this enhancement is marked as If you anticipate missing code freeze, you can file an exception request in advance. Thank you! |
Thanks @tjons. Yes, I agree this is at risk for code freeze. We have a separate tracking board for this feature here: https://github.com/orgs/kubernetes/projects/178/views/2, and there are quite a few more PRs that need to merge by Thursday. I will continue to push on these, but there's a good chance we miss the deadline. With so many PRs, it will be easier for me to add them after the fact to the PR description. |
Hello @tallclair 👋 Enhancements team here, Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.32 milestone. If you still wish to progress this enhancement in 1.32, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks! /milestone clear |
Exception has been filed. |
The v1.32 Release Team is APPROVING this Code Freeze exception request. The updated deadline is 19:00 PDT Tuesday, 12th November 2024. /milestone v1.32 |
@tallclair did the work get completed here on time? I was at Kubecon, so if you could point me in the direction yes/no that would be great. |
beta promotion did land in kubernetes/kubernetes#128682, but was reverted in kubernetes/kubernetes#128875 due to multiple issues |
So for 1.32, the state is that lots of work landed, but the feature remained in alpha |
cc @tjons , we need to update the tracking. |
Thanks for the update! Will remove this from the milestone accordingly /milestone clear |
/reopen A github workflow autoclosed when I set to done 🙃 sorry for the noise |
@haircommander: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Enhancement Description
This issue tracks a list of KEP review conversations that need resolving before we GA the feature.
Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement
Identify CRI changes needed for UpdateContainerResources API, define response message for UpdateContainerResourcesExtend UpdateContainerResources API to return info such as ‘not supported’, ‘not enough memory’, ‘successful’, ‘pending page evictions’ etc.Define expected behavior for runtime when UpdateContainerResources is invoked. Define timeout duration of the CRI call.Define behavior when multiple containers are being resized, and UpdateContainerResources fails for one or more containers.
Check with API reviewers if we can keep maps instead list of named sub-objects for ResizePolicy.Can we find a more intuitive name for ResizePolicy?
Can we use ResourceVersion to figure out the ordering of Pod resize requests?
Do we need to add back the ‘RestartPod’ resize policy? Is there a strong use-case for it?Alpha Feature Code Issues:
These are Items and issues discovered during code review that need further discussion and need to be addressed before Beta.
Can we figure out GetPodQOS differently once it is determined on pod create? See In-place Pod Vertical Scaling feature kubernetes#102884 (comment)Add real values to dockershim test for ContainerStatus.Resources In-place Pod Vertical Scaling feature kubernetes#102884 (comment)Change PodStatus.Resources from v1.ResourceRequirements to *v1.ResourceRequirementsThe text was updated successfully, but these errors were encountered: