Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A restart Never static pod does not recreate mirror pod when it is deleted #116483

Open
smarterclayton opened this issue Mar 10, 2023 · 6 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@smarterclayton
Copy link
Contributor

smarterclayton commented Mar 10, 2023

What happened?

We have never fully clarified the behavior of restart=Never mirror pods, but they currently behave in surprising ways. At minimum, the following questions should be answered and documented:

  1. Should the mirror pod be recreated if the kubelet detects it is missing?
  2. Should a terminal mirror pod block re-execution of a restart=Never static pod on kubelet restart?

/sig node

What did you expect to happen?

Uncertain

How can we reproduce it (as minimally and precisely as possible)?

  1. Create a restartPolicy=Never static pod
  2. wait for it to reach completion via mirror pod
  3. Delete the mirror pod
  4. Restart kubelet

Anything else we need to know?

No response

Kubernetes version

$ kubectl version
# paste output here

Cloud provider

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

@smarterclayton smarterclayton added the kind/bug Categorizes issue or PR as related to a bug. label Mar 10, 2023
@smarterclayton smarterclayton self-assigned this Mar 10, 2023
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 10, 2023
@aojea
Copy link
Member

aojea commented Mar 10, 2023

/sig node

static pods will benefit of a nice doc with an state machine diagram 😉

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 10, 2023
@SergeyKanzhelev SergeyKanzhelev added this to Triage in SIG Node Bugs Mar 10, 2023
@smarterclayton
Copy link
Contributor Author

I've got a state diagram deck incoming to complement these bugs

@sftim
Copy link
Contributor

sftim commented Mar 15, 2023

I've got a state diagram deck incoming to complement these bugs

Mermaid versions welcome, especially for the K8s docs

@SergeyKanzhelev
Copy link
Member

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 22, 2023
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Triaged in SIG Node Bugs Mar 22, 2023
@SergeyKanzhelev
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 22, 2023
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.
Development

No branches or pull requests

6 participants