Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service controller trigger update when service ipfamilies changes #116520

Merged
merged 2 commits into from Apr 24, 2023
Merged

service controller trigger update when service ipfamilies changes #116520

merged 2 commits into from Apr 24, 2023

Conversation

Dingshujie
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

when loadbancer service ipFamilies change from dualstack to single stack or from single stack to dualstack，service controller need to trigger update in cloud provider

Which issue(s) this PR fixes:

Fixes #116495

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 13, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 13, 2023
@Dingshujie
Copy link
Member Author

/assign @aojea

@aojea
Copy link
Member

aojea commented Mar 13, 2023

/lgtm
/assign @panslava @andrewsykim

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5f43679dc516613007d56fe0ef3ed8961c15e1d6

@panslava
Copy link
Contributor

/lgtm

seems fine, only small thing, that it strongly relies on the fact that first ipFamily can not change, which is true, and probably will continue being true

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 14, 2023
@Dingshujie
Copy link
Member Author

/lgtm

seems fine, only small thing, that it strongly relies on the fact that first ipFamily can not change, which is true, and probably will continue being true

service update validate L5176 defines User can upgrade (add another clusterIP or ipFamily) or can downgrade (remove secondary clusterIP or ipFamily), but CAN NOT change primary/secondary clusterIP || ipFamily UNLESS they are changing from/to/ON ExternalName

andrewsykim
andrewsykim reviewed Mar 14, 2023
View reviewed changes
staging/src/k8s.io/cloud-provider/controllers/service/controller.go
@@ -582,6 +582,12 @@ func (c *Controller) needsUpdate(oldService *v1.Service, newService *v1.Service)
return true
}

if len(oldService.Spec.IPFamilies) != len(newService.Spec.IPFamilies) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the order matter in this case? Should we check order in addition to length of ip families?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment #116520 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a comment in the code with this context?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a comment in the code with this context?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, add comment with this context. PTAL

@Dingshujie
trigger update event when service ipFamilies changes.
8cbe9fe 
Signed-off-by: DingShujie <dingshujie@huawei.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2023
andrewsykim
andrewsykim reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa41a0f197a305c28c9d2e657583478772c19c08

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, Dingshujie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@Dingshujie
update gofmt
c94a9a1 
Signed-off-by: DingShujie <dingshujie@huawei.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2023
@Dingshujie
Copy link
Member Author

Dingshujie commented Mar 15, 2023 •
edited

@andrewsykim @aojea PTAL

@dims
Copy link
Member

dims commented Apr 24, 2023

re-apply LGTM (after the gofmt update)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b1387f7cd9ce61f0521773b1e94b9c1c9db4c63d

@k8s-ci-robot k8s-ci-robot merged commit 4d70d1d into kubernetes:master Apr 24, 2023
11 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@cheftako cheftako Awaiting requested review from cheftako

@aojea aojea Awaiting requested review from aojea

@panslava panslava Awaiting requested review from panslava

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

Assignees

@dims dims

@aojea aojea

@andrewsykim andrewsykim

@panslava panslava

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

[dual-stack]support service ipFamilies update event in service controller
6 participants
@Dingshujie @k8s-ci-robot @aojea @panslava @dims @andrewsykim