Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit tests: Skip flaky tests on Windows (part 2) #116659

Merged
merged 1 commit into from May 24, 2023
Merged

unit tests: Skip flaky tests on Windows (part 2) #116659

merged 1 commit into from May 24, 2023

Conversation

claudiubelu
Copy link
Contributor

What type of PR is this?

/kind failing-test
/kind flake

/sig windows
/sig testing

/priority important-soon
/milestone v1.27

What this PR does / why we need it:

Some of the unit tests are currently flaky on Windows [0]. This commit skips them until they are resolved.

Fixes for the flakes have been proposed, but not merged yet [1][2].

[0] https://testgrid.k8s.io/sig-windows-signal#windows-unit-master
[1] #114607
[2] #115269

Which issue(s) this PR fixes:

Related: #51540

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 15, 2023
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Mar 15, 2023
@SergeyKanzhelev
Copy link
Member

/assign @ffromani

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Mar 15, 2023
marquiz
marquiz reviewed Mar 16, 2023
View reviewed changes
pkg/kubelet/stats/cri_stats_provider_windows_test.go Outdated
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// TODO: Remove skip once flakyness is resolved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some issue/PR that we could refer here to better understand when to enable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big +1 to this. IMO Skip is fine, TODO is fine, just need a reference to learn when we can re-evaluate (it was done for other TODO in this PR if I'm not mistaken?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, opened issues for the 2 flakes that didn't have any reference:

#116692
#116693

@marquiz
Copy link
Contributor

marquiz commented Mar 16, 2023

/assign @pacoxu

@marquiz marquiz moved this from Triage to Needs Reviewer in SIG Node PR Triage Mar 16, 2023
@pacoxu
Copy link
Member

pacoxu commented Mar 17, 2023

/lgtm
This temp fix LGTM if it blocked windows-unit-master.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 93e4cec276d7de7f2d9bea0b2d4d7cb9b1b5680e

@liggitt
Copy link
Member

liggitt commented Mar 22, 2023

moving test-only PRs out of the milestone since we're past test freeze
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.27 milestone Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2023
@claudiubelu
unit tests: Skip flaky tests on Windows (part 2)
0979d55 
Some of the unit tests are currently flaky on Windows. This commit
skips them until they are resolved.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2023
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 13, 2023
@claudiubelu
Copy link
Contributor Author

/milestone v1.28

1 similar comment
@claudiubelu
Copy link
Contributor Author

/milestone v1.28

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 3, 2023
@jsturtevant
Copy link
Contributor

/lgtm
/assign @derekwaynecarr @mrunalp

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4bd9165ecf6b982fe7de0298f8435a41b33462c5

@SergeyKanzhelev SergeyKanzhelev moved this from PRs - Needs Reviewer to PRs - Needs Approver in SIG Node CI/Test Board May 24, 2023
@SergeyKanzhelev
Copy link
Member

/cc @msau42

@k8s-ci-robot k8s-ci-robot requested a review from msau42 May 24, 2023 00:59
@msau42
Copy link
Member

msau42 commented May 24, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, mrunalp, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
pacoxu
pacoxu reviewed May 24, 2023
View reviewed changes
pkg/controller/volume/attachdetach/reconciler/reconciler_test.go
// TODO: Remove skip once https://github.com/kubernetes/kubernetes/issues/116693 is fixed.
if goruntime.GOOS == "windows" {
t.Skip("Skipping test on Windows.")
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#107414 is fixed by #116675 in April. So this can be removed now.

pacoxu
pacoxu reviewed May 24, 2023
View reviewed changes
pkg/kubelet/cm/devicemanager/manager_test.go
@@ -197,6 +197,10 @@ func TestDevicePluginReRegistration(t *testing.T) {
// While testing above scenario, plugin discovery and registration will be done using
// Kubelet probe based mechanism
func TestDevicePluginReRegistrationProbeMode(t *testing.T) {
// TODO: Remove skip once https://github.com/kubernetes/kubernetes/pull/115269 merges.

This comment was marked as abuse.

Sign in to view

@k8s-ci-robot k8s-ci-robot merged commit 484645e into kubernetes:master May 24, 2023
15 checks passed
SIG Node CI/Test Board automation moved this from PRs - Needs Approver to Done May 24, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz left review comments

@pacoxu pacoxu pacoxu left review comments

@mrunalp mrunalp mrunalp approved these changes

@bobbypage bobbypage Awaiting requested review from bobbypage

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@ffromani ffromani Awaiting requested review from ffromani

@msau42 msau42 Awaiting requested review from msau42

Assignees

@jsturtevant jsturtevant

@pacoxu pacoxu

@derekwaynecarr derekwaynecarr

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
[sig-release] Bug Triage
Archived in project
[sig-windows] PR tracking
Status: Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet