Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated pkg/scheduler/framework/plugins/podtopologyspread to contextual logging #116797

Merged
merged 1 commit into from Apr 27, 2023
Merged

Migrated pkg/scheduler/framework/plugins/podtopologyspread to contextual logging #116797

merged 1 commit into from Apr 27, 2023

Conversation

mengjiao-liu
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Migrated pkg/scheduler/framework/plugins/podtopologyspread to contextual logging

Which issue(s) this PR fixes:

Part of #91633 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Migrated the podtopologyspread scheduler plugins to use [contextual logging](https://k8s.io/docs/concepts/cluster-administration/system-logs/#contextual-logging).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3077-contextual-logging

/sig instrumentation
/wg structured-logging
/area logging
/sig scheduling

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/logging sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 21, 2023
@mengjiao-liu
Copy link
Member Author

/test all

@mengjiao-liu mengjiao-liu mentioned this pull request Mar 21, 2023
Open
@mengjiao-liu mengjiao-liu marked this pull request as ready for review March 23, 2023 08:59
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2023
@logicalhan
Copy link
Member

/triage accepted
/assign @pohly

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 23, 2023
kerthcet
kerthcet reviewed Mar 29, 2023
View reviewed changes
Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally LGTM to me.

pkg/scheduler/framework/plugins/podtopologyspread/filtering.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/podtopologyspread/filtering.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/podtopologyspread/filtering_test.go Show resolved Hide resolved
@mengjiao-liu mengjiao-liu force-pushed the contextual-looging-scheduler-plugin-podtopologyspread branch from ffaadcf to 9d1a0d5 Compare March 31, 2023 09:18
@mengjiao-liu
Copy link
Member Author

/test pull-kubernetes-unit

@mengjiao-liu mengjiao-liu force-pushed the contextual-looging-scheduler-plugin-podtopologyspread branch from 9d1a0d5 to 7f370d6 Compare April 27, 2023 07:55
kerthcet
kerthcet reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @alculquicondor

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2ef0080c85e8e4d71cea64f5fe599626d1de04dc

alculquicondor
alculquicondor reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

pkg/scheduler/framework/plugins/podtopologyspread/filtering.go
Comment on lines 277 to +278
if node == nil {
klog.ErrorS(nil, "Node not found")
logger.Error(nil, "Node not found")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added this log line several releases ago when it was possible for us to have nil nodes in the cache.

We no longer have those. We can remove this log line to avoid the FromContext

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mengjiao-liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit b44482a into kubernetes:master Apr 27, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 27, 2023
@kerthcet kerthcet mentioned this pull request May 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@kerthcet kerthcet kerthcet left review comments

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@pohly pohly

@alculquicondor alculquicondor

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mengjiao-liu @k8s-ci-robot @logicalhan @pohly @alculquicondor @kerthcet