Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publishing-bot rules for the new release-1.27 branch #116919

Merged
merged 1 commit into from
Mar 25, 2023
Merged

publishing-bot rules for the new release-1.27 branch #116919

merged 1 commit into from
Mar 25, 2023

Conversation

dims
Copy link
Member

@dims dims commented Mar 24, 2023 •
edited
Loading

Duh! someone missed a step. We need these rules populated when we cut a new branch.

/kind bug

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #116912

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.27 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.27.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Mar 24 16:22:46 UTC 2023.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2023
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Mar 24, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sttts March 24, 2023 21:51
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 24, 2023
@dims
Copy link
Member Author

dims commented Mar 24, 2023

/milestone v1.27
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 24, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 24, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 24, 2023
@dims
Copy link
Member Author

dims commented Mar 24, 2023

/cc @kubernetes/sig-release-leads @kubernetes/sig-release

@k8s-ci-robot
Copy link
Contributor

@dims: GitHub didn't allow me to request PR reviews from the following users: kubernetes/sig-release-leads, kubernetes/sig-release.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kubernetes/sig-release-leads @kubernetes/sig-release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Member Author

dims commented Mar 24, 2023

/assign @liggitt

/hold for @salaxander

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2023
@liggitt
Copy link
Member

liggitt commented Mar 24, 2023

was this generated with the rules tool? I remember we did this by hand for 1.26 and messed it up a little

@cici37
Copy link
Contributor

cici37 commented Mar 24, 2023

Thank you @dims ! We plan to do it today and you beat us on speed^^
cc @gracenng @ramrodo
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 72f93d9aac0d08b7c65679baf9a028211855bce9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cici37, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
publishing-bot rules for the new release-1.27 branch
1ad7cac 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the publishing-bot-rules-for-new-release-1.27-branch branch from 69597e8 to 1ad7cac Compare March 24, 2023 22:09
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023
@dims
Copy link
Member Author

dims commented Mar 24, 2023

was this generated with the rules tool? I remember we did this by hand for 1.26 and messed it up a little

yep i tried a bit by hand, it was getting hard :) then used

_output/update-rules -branch release-1.27 -go 1.20.2 -o /tmp/rules.yaml -rules /Users/davanum/go/src/k8s.io/kubernetes/staging/publishing/rules.yaml

@cici37
Copy link
Contributor

cici37 commented Mar 24, 2023

Just fyi we also have docker run -t gcr.io/k8s-staging-publishing-bot/publishing-bot:latest /update-rules for such work. :)
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c8580d32105529a44d70b4e9b6ccdf618958ede9

@cici37 cici37 mentioned this pull request Mar 24, 2023
Closed
12 tasks
@dims
Copy link
Member Author

dims commented Mar 24, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2023
@dims dims mentioned this pull request Mar 25, 2023
Closed
@liggitt
Copy link
Member

liggitt commented Mar 25, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8f15859 into kubernetes:master Mar 25, 2023
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.27, v1.28 Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato Awaiting requested review from cpanato

@sttts sttts Awaiting requested review from sttts

@cici37 cici37 Awaiting requested review from cici37

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@cici37 cici37

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

Go modules are not tagged for v0.27.0-rc.0
4 participants
@dims @k8s-ci-robot @liggitt @cici37