-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unittests: Fixes server journal unit test on Windows #117136
unittests: Fixes server journal unit test on Windows #117136
Conversation
The Boot option for the node log query is not supported on Windows and an error is returned if the option is set. Because of this, one of the unit tests which sets the option fails, as it does not expect any errror.
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Apr 6 07:59:36 UTC 2023. |
/triage accepted |
LGTM label has been added. Git tree hash: 90c9fd78e6fcb0744c318b9d61039da3a43850ba
|
/milestone v1.28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/milestone v1.28 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: claudiubelu, mrunalp, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind failing-test
/sig windows
/sig testing
/priority important-soon
What this PR does / why we need it:
The Boot option for the node log query is not supported on Windows and an error is returned if the option is set. Because of this, one of the unit tests which sets the option fails, as it does not expect any errror.
Sample error: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-unit-windows-master/1643774435150270464
Which issue(s) this PR fixes:
Related: #51540
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: