Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plState := cfgCtlr.priorityLevelStates[plName]. It may not exist and the plState may be nil。 #117203

Open
tm-worker opened this issue Apr 11, 2023 · 16 comments
Assignees
Labels
area/apiserver kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@tm-worker
Copy link

plState := cfgCtlr.priorityLevelStates[plName]

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 11, 2023
@tm-worker
Copy link
Author

/sig apiserver

@k8s-ci-robot
Copy link
Contributor

@tm-worker: The label(s) sig/apiserver cannot be applied, because the repository doesn't have them.

In response to this:

/sig apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tm-worker
Copy link
Author

/sig area/apiserver

@k8s-ci-robot
Copy link
Contributor

@tm-worker: The label(s) sig/area/apiserver cannot be applied, because the repository doesn't have them.

In response to this:

/sig area/apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tm-worker
Copy link
Author

area/apiserver

1 similar comment
@xxwwbb3
Copy link

xxwwbb3 commented Apr 11, 2023

area/apiserver

@tm-worker
Copy link
Author

/sig/area/apiserver

@xxwwbb3
Copy link

xxwwbb3 commented Apr 11, 2023

/area apiserver

@tm-worker
Copy link
Author

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 11, 2023
@kannon92
Copy link
Contributor

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 14, 2023
@fedebongio
Copy link
Contributor

This is Priority and Fairness, so assigning people accordingly to take a look:
/assign @MikeSpreitzer @tkashem @lavalamp
/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 20, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 20, 2023
@lavalamp
Copy link
Member

Can you share a stack trace or something? This isn't much to go on.

@tm-worker
Copy link
Author

tm-worker commented Apr 28, 2023

Can you share a stack trace or something? This isn't much to go on.

There was no nil check when using plState. but why ?

@MikeSpreitzer
Copy link
Member

Because https://github.com/kubernetes/kubernetes/blob/ad18954259eae3db51bac2274ed4ca7304b923c4/staging/src/k8s.io/apiserver/pkg/util/flowcontrol/apf_controller.go#L728C2-L730, and the ensuring that the mandatory priority levels are represented, makes sure that only extant priority levels are referenced.

@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 7, 2024
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label May 16, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apiserver kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

9 participants