Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: update opencontainers/selinux to v1.11.0 #117326

Merged
merged 1 commit into from
Sep 7, 2023
Merged

dependencies: update opencontainers/selinux to v1.11.0 #117326

merged 1 commit into from
Sep 7, 2023

Conversation

akhilerm
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • updates opencontainers/selinux to v1.11.0

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/dependency Issues or PRs related to dependency changes labels Apr 14, 2023
@akhilerm
Copy link
Member Author

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims April 14, 2023 05:41
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2023
@dims
Copy link
Member

dims commented Apr 25, 2023

/sig node
/assign @SergeyKanzhelev @mrunalp

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 25, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 25, 2023
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Apr 25, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Apr 25, 2023

/release-note-none
/triage accepted
/priority important-longterm
/lgtm
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 25, 2023
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 25, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2023
@akhilerm
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@akhilerm
Copy link
Member Author

/cc @jsafrane

Pinging to see if the update will cause regression in selinux, (context: selinux volume relabelling as mentioned in the comment above)

@jsafrane
Copy link
Member

I don't know. We don't have e2e tests for volume relabeling done by the container runtime. As I wrote, I added tests for SELinuxMount feature, but that's not how are volumes relabeled today.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2023
@akhilerm
dependencies: update opencontainers/selinux to v1.11.0
214772c 
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2023
@akhilerm
Copy link
Member Author

akhilerm commented Sep 4, 2023

@liggitt What should we do about this PR?

@liggitt
Copy link
Member

liggitt commented Sep 5, 2023

still looking for storage reviewer and test coverage

@jsafrane
Copy link
Member

jsafrane commented Sep 6, 2023

It looks good from storage perspective.

@liggitt
Copy link
Member

liggitt commented Sep 6, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a75dedb62099a020effc1f7e34fd02a2059c8f5e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhilerm, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2023
@pacoxu
Copy link
Member

pacoxu commented Sep 7, 2023

/retest
/skip

@pacoxu
Copy link
Member

pacoxu commented Sep 7, 2023

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 4f303d1 into kubernetes:master Sep 7, 2023
15 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Sep 7, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 7, 2023
@akhilerm akhilerm deleted the update-selinux branch September 7, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@logicalhan logicalhan Awaiting requested review from logicalhan

@dims dims Awaiting requested review from dims

@bart0sh bart0sh Awaiting requested review from bart0sh

@liggitt liggitt Awaiting requested review from liggitt

@mrunalp mrunalp Awaiting requested review from mrunalp

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@mrunalp mrunalp

@liggitt liggitt

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@akhilerm @dims @bart0sh @k8s-ci-robot @liggitt @jsafrane @pacoxu @mrunalp @SergeyKanzhelev