Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #117449: e2e: fix flaky test 'should contain OpenAPI V3 for Aggregated #117486

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Automated cherry pick of #117449: e2e: fix flaky test 'should contain OpenAPI V3 for Aggregated #117486

merged 1 commit into from
Aug 2, 2023

Conversation

TommyStarK
Copy link
Contributor

@TommyStarK TommyStarK commented Apr 19, 2023 •
edited

Cherry pick of #117449 on release-1.27.

#117449: e2e: fix flaky test 'should contain OpenAPI V3 for Aggregated

For details on the cherry pick process, see the cherry pick requests page.

NONE

@TommyStarK
e2e: fix flaky test 'should contain OpenAPI V3 for Aggregated APIServer'
0711be3 
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added area/test do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @TommyStarK. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 19, 2023
@TommyStarK
Copy link
Contributor Author

@Jefftree backport the fix to 1.27. If there is anything don't hesitate :)

@Jefftree
Copy link
Member

/ok-to-test
/lgtm
/assign @lavalamp

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c088b386ebe738eb1df2e345d80e920f41adf2df

@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 20, 2023
@k8s-ci-robot k8s-ci-robot requested a review from Verolop July 2, 2023 10:36
@k8s-ci-robot k8s-ci-robot requested a review from cici37 July 20, 2023 07:28
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 23, 2023
@TommyStarK
Copy link
Contributor Author

/kind flake

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 23, 2023
@TommyStarK
Copy link
Contributor Author

/cc @Verolop @cici37 @xmudrii @saschagrunert

@TommyStarK
Copy link
Contributor Author

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Aug 2, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
xmudrii
xmudrii approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RelEng:
/lgtm
/approve

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 2, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, TommyStarK, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 579208d into kubernetes:release-1.27 Aug 2, 2023
13 checks passed
@TommyStarK TommyStarK deleted the automated-cherry-pick-of-#117449-upstream-release-1.27 branch August 2, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@cheftako cheftako Awaiting requested review from cheftako

@sttts sttts Awaiting requested review from sttts

@Verolop Verolop Awaiting requested review from Verolop

@cici37 cici37 Awaiting requested review from cici37

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees

@lavalamp lavalamp

@liggitt liggitt

@Jefftree Jefftree

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@TommyStarK @k8s-ci-robot @Jefftree @fedebongio @liggitt @xmudrii @lavalamp