Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fix flaky test 'should contain OpenAPI V3 for Aggregated APIServer' #117449

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

TommyStarK
Copy link
Contributor

What type of PR is this?

/kind flake

What this PR does / why we need it:

If applied this commit will deflake the e2e test "should contain OpenAPI V3 for Aggregated APIServer"

Which issue(s) this PR fixes:

Fixes #117443

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 18, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @TommyStarK. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 18, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 18, 2023
@TommyStarK
Copy link
Contributor Author

TommyStarK commented Apr 18, 2023

Hello @aojea,
I tried to go with the simplest way without too messing with the e2e code with which I am not comfortable at all 😅 . If I misunderstood something or if you do not feel comfortable with this PR, please let me know.
I'll take time tomorrow to rebuild and re-run all the apimachinery e2e tests on a better computer.
Remaining at your disposal.

Best,

@aojea
Copy link
Member

aojea commented Apr 18, 2023

/ok-to-test

This duplication seems to be added here, please see #117443 for context
/assign @apelisse @lavalamp @Jefftree

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 18, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 18, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2023
@TommyStarK TommyStarK changed the title e2e: fix flaky test, should contain OpenAPI V3 for Aggregated APIServer e2e: fix flaky test 'should contain OpenAPI V3 for Aggregated APIServer' Apr 19, 2023
@TommyStarK TommyStarK force-pushed the e2e/gh_117443 branch 2 times, most recently from 99feab3 to c5e0963 Compare April 19, 2023 05:24
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
@TommyStarK
Copy link
Contributor Author

TommyStarK commented Apr 19, 2023

@aojea I found a way to give another name for the test 'OpenAPI V3 aggregated server' without messing too much with the existing code. Feel free to tell me if you do not feel comfortable with that approach or if you had something else in mind.

Best,

@apelisse
Copy link
Member

Have you tried pinging the people who know the most about this? @Jefftree @alexzielenski

@apelisse
Copy link
Member

Oh I see Jeff was pinged, good :-)

@TommyStarK
Copy link
Contributor Author

Yes we did :) At your disposal if there is any change to make

@Jefftree
Copy link
Member

Thanks for the fix! This is definitely better than forcing the two tests to run in serial.

LGTM

@Jefftree
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 01f350c2f654c05c712834b3073d81b44d18525f

@lavalamp
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, lavalamp, TommyStarK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2023
@Jefftree
Copy link
Member

I think it makes sense to also backport this to v1.27 once merged.

@TommyStarK
Copy link
Contributor Author

If you want me to create the cherry-pick to backport it to 1.27, please tell me :) Thank you for the review

@TommyStarK
Copy link
Contributor Author

CI failure does not seem to be related with my changes

Screenshot 2023-04-19 at 19 56 49

/retest-required

1 similar comment
@TommyStarK
Copy link
Contributor Author

CI failure does not seem to be related with my changes

Screenshot 2023-04-19 at 19 56 49

/retest-required

@k8s-ci-robot k8s-ci-robot merged commit 10d9d4b into kubernetes:master Apr 19, 2023
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 19, 2023
@TommyStarK TommyStarK deleted the e2e/gh_117443 branch April 19, 2023 19:59
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 20, 2023
@aojea
Copy link
Member

aojea commented Apr 24, 2023

Thanks

k8s-ci-robot added a commit that referenced this pull request Aug 2, 2023
…117449-upstream-release-1.27

Automated cherry pick of #117449: e2e: fix flaky test 'should contain OpenAPI V3 for Aggregated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test - should contain OpenAPI V3 for Aggregated APIServer
7 participants