-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: fix flaky test 'should contain OpenAPI V3 for Aggregated APIServer' #117449
Conversation
Hi @TommyStarK. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hello @aojea, Best, |
60cd56b
to
89c9a80
Compare
99feab3
to
c5e0963
Compare
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
c5e0963
to
a02e94a
Compare
@aojea I found a way to give another name for the test 'OpenAPI V3 aggregated server' without messing too much with the existing code. Feel free to tell me if you do not feel comfortable with that approach or if you had something else in mind. Best, |
Have you tried pinging the people who know the most about this? @Jefftree @alexzielenski |
Oh I see Jeff was pinged, good :-) |
Yes we did :) At your disposal if there is any change to make |
Thanks for the fix! This is definitely better than forcing the two tests to run in serial. LGTM |
/lgtm |
LGTM label has been added. Git tree hash: 01f350c2f654c05c712834b3073d81b44d18525f
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jefftree, lavalamp, TommyStarK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think it makes sense to also backport this to v1.27 once merged. |
If you want me to create the cherry-pick to backport it to 1.27, please tell me :) Thank you for the review |
1 similar comment
/triage accepted |
Thanks |
…117449-upstream-release-1.27 Automated cherry pick of #117449: e2e: fix flaky test 'should contain OpenAPI V3 for Aggregated
What type of PR is this?
/kind flake
What this PR does / why we need it:
If applied this commit will deflake the e2e test "should contain OpenAPI V3 for Aggregated APIServer"
Which issue(s) this PR fixes:
Fixes #117443
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: