Adding more callbacks in kubedrain helper

[adilGhaffarDev]

What type of PR is this?

/kind feature

Which issue(s) this PR fixes:

Fixes #116210

Does this PR introduce a user-facing change?

- Added kubectl node drain helper callbacks `OnPodDeletionOrEvictionStarted` and `OnPodDeletionOrEvictionFailed`; people extending `kubectl` can use these new callbacks for more granularity.
- Deprecated the `OnPodDeletedOrEvicted` node drain helper callback.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

[k8s-ci-robot]

Welcome @adilGhaffarDev!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @adilGhaffarDev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adilGhaffarDev]

/hold

[k8s-triage-robot]

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

[adilGhaffarDev]

/unhold

[soltysh]

/test pull-kubernetes-node-e2e-containerd

[soltysh]

/triage accepted
/priority important-longterm

[soltysh]

Are you sure you want to have the hook invoked even in dry-run mode? Even if it's a server one.

[adilGhaffarDev]

other hooks are not invoked in DryRunServer, I will remove this one too.

[soltysh]

I'd expect drain command not to use the old methods, but only the new hooks. Especially that if you have both OnPodDeletedOrEvicted and OnPodDeletionOrEvictionFinished defined, only the latter is being used, right?

[soltysh]

With your current implementation if I invoke kubectl drain -v=2 you'll get pod printed more than necessary. I don't think that's necessary, I'd like to maintain the current behavior of the drain command, so you need to make sure that whatever changes under the covers the command invocation stays the same.

[adilGhaffarDev]

checking verbosity level while creating NewDrainCmdOptions should fix this right? like this:

func NewDrainCmdOptions(f cmdutil.Factory, ioStreams genericiooptions.IOStreams) *DrainCmdOptions {
	o := &DrainCmdOptions{
		PrintFlags: genericclioptions.NewPrintFlags("drained").WithTypeSetter(scheme.Scheme),
		IOStreams:  ioStreams,
		drainer: &drain.Helper{
			GracePeriodSeconds: -1,
			Out:                ioStreams.Out,
			ErrOut:             ioStreams.ErrOut,
			ChunkSize:          cmdutil.DefaultChunkSize,
		},
	}
	if !klog.V(2).Enabled() {
		o.drainer.OnPodDeletedOrEvicted = o.onPodDeletedOrEvicted
	} else {
		o.drainer.OnPodDeletionOrEvictionFinished = o.onPodDeletionOrEvictionFinished
		o.drainer.OnPodDeletionOrEvictionStarted = o.onPodDeletionOrEvictionStarted
	}
	return o
}

[soltysh]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: ac6af520f274643dfcebbd6abef2c8dd63b06b4e

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/kubectl/OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sftim]

Changelog suggestion

- Added kubectl node drain helper callbacks `OnPodDeletionOrEvictionStarted` and `OnPodDeletionOrEvictionFailed`; people extending `kubectl` can use these new callbacks for more granularity.
- Deprecated the `OnPodDeletedOrEvicted` node drain helper callback.

[adilGhaffarDev]

Changelog suggestion

- Added kubectl node drain helper callbacks `OnPodDeletionOrEvictionStarted` and `OnPodDeletionOrEvictionFailed`; people extending `kubectl` can use these new callbacks for more granularity.

- Deprecated the `OnPodDeletedOrEvicted` node drain helper callback.

@sftim should I create separate PR for this?

[sftim]

You can edit the PR description for this PR @adilGhaffarDev

[adilGhaffarDev]

can we cherrypick this to v1.28?