Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: fix unit test panic for TestNewResetData #117530

Merged
merged 1 commit into from Apr 22, 2023

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Apr 22, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

When multiple CRI endpoints on the host:

go test -timeout 30s -run ^TestNewResetData$ k8s.io/kubernetes/cmd/kubeadm/app/cmd

--- FAIL: TestNewResetData (0.00s)
    --- FAIL: TestNewResetData/pre-flights_errors_from_CLI_args (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0x101886dcd]

goroutine 51 [running]:
testing.tRunner.func1.2({0x101ae3ae0, 0x1031c3ac0})
        /Users/machine/workspace/soft/go/src/testing/testing.go:1526 +0x24e
testing.tRunner.func1()
        /Users/machine/workspace/soft/go/src/testing/testing.go:1529 +0x39f
panic({0x101ae3ae0, 0x1031c3ac0})
        /Users/machine/workspace/soft/go/src/runtime/panic.go:884 +0x213
k8s.io/kubernetes/cmd/kubeadm/app/cmd.expectedResetIgnorePreflightErrors.func1(0xc0004d46e0?, 0xc0003807e0?)
        /Users/machine/workspace/gopath/src/k8s.io/kubernetes/cmd/kubeadm/app/cmd/reset_test.go:110 +0x2d
k8s.io/kubernetes/cmd/kubeadm/app/cmd.TestNewResetData.func1(0xc0004d3ba0)
        /Users/machine/workspace/gopath/src/k8s.io/kubernetes/cmd/kubeadm/app/cmd/reset_test.go:102 +0x5e3
testing.tRunner(0xc0004d3ba0, 0xc00039cda0)
        /Users/machine/workspace/soft/go/src/testing/testing.go:1576 +0x10b
created by testing.(*T).Run
        /Users/machine/workspace/soft/go/src/testing/testing.go:1629 +0x3ea
FAIL    k8s.io/kubernetes/cmd/kubeadm/app/cmd   0.642s
FAIL

we need to pass a predefined CRI endpoint in CLI flag for unit tests.

Which issue(s) this PR fixes:

Ref kubernetes/kubeadm#2863

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 22, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 22, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2023
@SataQiu
Copy link
Member Author

SataQiu commented Apr 22, 2023

/assign @chendave

@SataQiu
Copy link
Member Author

SataQiu commented Apr 22, 2023

/retest

Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 15d4a4bfebbd800d4006e00c21d1c4513c2a1dde

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b214488 into kubernetes:master Apr 22, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants