Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster/gce: update cloud-provider-gcp image to latest tagged version #117605

Merged
merged 2 commits into from Apr 26, 2023
Merged

cluster/gce: update cloud-provider-gcp image to latest tagged version #117605

merged 2 commits into from Apr 26, 2023

Conversation

andrewsykim
Copy link
Member

@andrewsykim andrewsykim commented Apr 26, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update cloud-provider-gcp image used in CI to latest tagged version based on 1.26

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 26, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 26, 2023
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 26, 2023
andrewsykim
andrewsykim commented Apr 26, 2023
View reviewed changes
cluster/gce/manifests/cloud-controller-manager.manifest
@@ -23,7 +23,7 @@
"containers":[
{
"name": "cloud-controller-manager",
"image": "gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:v1.25.2-alpha_ae91c1fc0c443c464a4c878ffa2a4544483c6d1f",
"image": "gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:v26.2.4",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I still had to push this tag manually as we don't publish this image yet as part of the cloud-provider-gcp release process. cc @jprzychodzen

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add commands how you push image to https://github.com/kubernetes/cloud-provider-gcp/blob/master/docs/instruction-how-to-bump-repository.md ?

@andrewsykim
Copy link
Member Author

/test pull-e2e-gce-cloud-provider-disabled

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 26, 2023
@andrewsykim andrewsykim mentioned this pull request Apr 26, 2023
Closed
andrewsykim
andrewsykim commented Apr 26, 2023
View reviewed changes
cluster/gce/manifests/cloud-controller-manager.manifest
"resources": {
"requests": {
"cpu": "{{cpurequest}}"
}
},
"command": ["/cloud-controller-manager"],
"args": [
"--log-file=/var/log/cloud-controller-manager.log",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing temporarily to see if CI will go green, opened kubernetes/cloud-provider-gcp#520 to follow-up

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is stale, referenced issue explain the problem, cloud-provider-gcp moved to go-runner

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@andrewsykim
Copy link
Member Author

/test pull-e2e-gce-cloud-provider-disabled

@andrewsykim
cluster/gce: update cloud-provider-gcp image to latest tagged version
0d27d3c 
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
@andrewsykim
cluster/gce: update cloud-controller-manager to use go-runner
96eaed9 
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
@andrewsykim
Copy link
Member Author

/test pull-e2e-gce-cloud-provider-disabled

@aojea
Copy link
Member

aojea commented Apr 26, 2023

/assign

@aojea
Copy link
Member

aojea commented Apr 26, 2023

sweeet, it works fine now https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/117605/pull-e2e-gce-cloud-provider-disabled/1651183969196052480/artifacts/e2e-259cc44a81-3e477-master/cloud-controller-manager.log

/lgtm
/approve

@andrewsykim as a follow up, if needed, I can see in the logs the route controller is running

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e3a060e8e5f6d88bcefbbc5efb5ca1e0b72df32b

@aojea
Copy link
Member

aojea commented Apr 26, 2023

/assign @dims

we need a cluster level approver

@dims
Copy link
Member

dims commented Apr 26, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, aojea, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit afeb78f into kubernetes:master Apr 26, 2023
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@aojea aojea aojea left review comments

@jprzychodzen jprzychodzen jprzychodzen left review comments

@cjcullen cjcullen Awaiting requested review from cjcullen

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@dims dims

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andrewsykim @k8s-ci-robot @aojea @dims @jprzychodzen