-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster/gce: update cloud-provider-gcp image to latest tagged version #117605
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,16 +23,17 @@ | |
"containers":[ | ||
{ | ||
"name": "cloud-controller-manager", | ||
"image": "gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:v1.25.2-alpha_ae91c1fc0c443c464a4c878ffa2a4544483c6d1f", | ||
"image": "gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:v26.2.4", | ||
"resources": { | ||
"requests": { | ||
"cpu": "{{cpurequest}}" | ||
} | ||
}, | ||
"command": ["/cloud-controller-manager"], | ||
"args": [ | ||
"--log-file=/var/log/cloud-controller-manager.log", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing temporarily to see if CI will go green, opened kubernetes/cloud-provider-gcp#520 to follow-up There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this comment is stale, referenced issue explain the problem, cloud-provider-gcp moved to go-runner There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks! |
||
"--logtostderr=false", | ||
"--also-stdout=false", | ||
"--redirect-stderr=true", | ||
"/cloud-controller-manager", | ||
{{params}} | ||
], | ||
{{container_env}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I still had to push this tag manually as we don't publish this image yet as part of the cloud-provider-gcp release process. cc @jprzychodzen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add commands how you push image to https://github.com/kubernetes/cloud-provider-gcp/blob/master/docs/instruction-how-to-bump-repository.md ?