Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster/gce: update cloud-provider-gcp image to latest tagged version #117605

Merged
merged 2 commits into from
Apr 26, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions cluster/gce/manifests/cloud-controller-manager.manifest
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,17 @@
"containers":[
{
"name": "cloud-controller-manager",
"image": "gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:v1.25.2-alpha_ae91c1fc0c443c464a4c878ffa2a4544483c6d1f",
"image": "gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:v26.2.4",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I still had to push this tag manually as we don't publish this image yet as part of the cloud-provider-gcp release process. cc @jprzychodzen

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"resources": {
"requests": {
"cpu": "{{cpurequest}}"
}
},
"command": ["/cloud-controller-manager"],
"args": [
"--log-file=/var/log/cloud-controller-manager.log",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing temporarily to see if CI will go green, opened kubernetes/cloud-provider-gcp#520 to follow-up

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is stale, referenced issue explain the problem, cloud-provider-gcp moved to go-runner

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

"--logtostderr=false",
"--also-stdout=false",
"--redirect-stderr=true",
"/cloud-controller-manager",
{{params}}
],
{{container_env}}
Expand Down