Fix image pull error type ErrRegistryUnavailable
#117612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/kubelet
sig/node
The current error comparison `imagePullResult.err == ErrRegistryUnavailable` will never work with any remote runtime, because we produce gRPC errors which wrap a code and a description, like: ``` rpc error: code = Unknown desc = This is the error description ``` To be able to check custom error types from `pkg/kubelet/images/types.go`, we now strip the code if the status is unknown on image pull. Beside that, we use a string comparison to check against `ErrRegistryUnavailable.Error()`, because validating them via the `errors` package is not yet supported by grpc-go: grpc/grpc-go#3616 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
image-pull-errors
branch
from
65b5bb1
to
4cdfe60
Compare
saschagrunert
added a commit
to saschagrunert/cri-o
that referenced
this pull request
Apr 26, 2023
If we agree on the fix in kubernetes/kubernetes#117612, then we can support the `RegistryUnavailable` error message as well. This has the benefit that we display the information directly to the end user as better error indicator. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
/test pull-kubernetes-node-e2e-containerd |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 30aac63ae5ce3ac31eacd8cd56c9a5d448ce7ea1
|
mrunalp
approved these changes
May 2, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
saschagrunert
added a commit
to saschagrunert/cri-o
that referenced
this pull request
May 3, 2023
If we agree on the fix in kubernetes/kubernetes#117612, then we can support the `RegistryUnavailable` error message as well. This has the benefit that we display the information directly to the end user as better error indicator. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/cri-o
that referenced
this pull request
May 3, 2023
If we agree on the fix in kubernetes/kubernetes#117612, then we can support the `RegistryUnavailable` error message as well. This has the benefit that we display the information directly to the end user as better error indicator. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The current error comparison
imagePullResult.err == ErrRegistryUnavailablewill never work with any remote runtime, because we produce gRPC errors which wrap a code and a description, like:To be able to check custom error types from
pkg/kubelet/images/types.go, we now strip the code if the status is unknown on image pull.Beside that, we use a string comparison to check against
ErrRegistryUnavailable.Error(), because validating them via theerrorspackage is not yet supported by grpc-go: grpc/grpc-go#3616Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: