Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable NewVolumeManagerReconstruction and SELinuxMountReadWriteOncePod feature gate #117751

Merged
merged 1 commit into from May 4, 2023
Merged

Disable NewVolumeManagerReconstruction and SELinuxMountReadWriteOncePod feature gate #117751

merged 1 commit into from May 4, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 3, 2023 •
edited

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Reverts the NewVolumeManagerReconstruction feature gate to disabled until #117745 is root-caused and resolved

Does this PR introduce a user-facing change?

Fixes a 1.27 regression by reverting NewVolumeManagerReconstruction and SELinuxMountReadWriteOncePod feature gates to disabled by default to resolve a regression of volume reconstruction on kubelet/node restart

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig storage
/assign @msau42 @jsafrane

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 3, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. labels May 3, 2023
@k8s-ci-robot k8s-ci-robot added kind/regression Categorizes issue or PR as related to a regression from a prior release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 3, 2023
@liggitt liggitt mentioned this pull request May 3, 2023
Merged
@dims
Copy link
Member

dims commented May 3, 2023 •
edited

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e42e1e231103dd5fe6cfe19b43fc3d71c8e3bf96

@dims
Copy link
Member

dims commented May 3, 2023

cc @msau42 @xing-yang

@dims
Copy link
Member

dims commented May 3, 2023

/triage accepted
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 3, 2023
@liggitt
Copy link
Member Author

liggitt commented May 3, 2023

/hold for storage ack

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@msau42
Copy link
Member

msau42 commented May 3, 2023

@jsafrane if we disable this feature gate, should we also disable SELinuxMount feature gate and hold off on the backport of #116134 (comment)?

@liggitt liggitt force-pushed the disable-NewVolumeManagerReconstruction branch from f629730 to d0529d0 Compare May 4, 2023 13:29
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from dims May 4, 2023 13:29
@jsafrane
Copy link
Member

jsafrane commented May 4, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 634a420c746cb0ff3a0d4afa4b0f340b4b262738

@liggitt liggitt changed the title Disable NewVolumeManagerReconstruction feature gate Disable NewVolumeManagerReconstruction and SELinuxMountReadWriteOncePod feature gate May 4, 2023
@liggitt liggitt force-pushed the disable-NewVolumeManagerReconstruction branch from d0529d0 to 7a3b9f8 Compare May 4, 2023 13:41
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@liggitt
Copy link
Member Author

liggitt commented May 4, 2023

repushed with a comment linking to the issue beside the SELinuxMountReadWriteOncePod feature gate

@liggitt
Copy link
Member Author

liggitt commented May 4, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@liggitt
Copy link
Member Author

liggitt commented May 4, 2023

grrr... unit tests assuming the feature gate is on, fixing...

@liggitt liggitt force-pushed the disable-NewVolumeManagerReconstruction branch from 7a3b9f8 to c8c7cd2 Compare May 4, 2023 17:38
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 4, 2023
@liggitt
Copy link
Member Author

liggitt commented May 4, 2023

fixed unit test and added comprehensive unit tests of update validation with the feature enabled/disabled

@aojea
Copy link
Member

aojea commented May 4, 2023

@liggitt still failing those unit tests

@liggitt liggitt force-pushed the disable-NewVolumeManagerReconstruction branch from c8c7cd2 to e807a6a Compare May 4, 2023 20:41
@liggitt
Copy link
Member Author

liggitt commented May 4, 2023

was a separate package, fixed

@aojea
Copy link
Member

aojea commented May 4, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 07120f02c0d523b15f9f4d80577ef3e42ff47ae9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fa487b0 into kubernetes:master May 4, 2023
12 of 13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 4, 2023
k8s-ci-robot added a commit that referenced this pull request May 5, 2023
@k8s-ci-robot
Merge pull request #117752 from liggitt/automated-cherry-pick-of-#117…
ddd0316 
…751-upstream-release-1.27

Automated cherry pick of #117751: Disable NewVolumeManagerReconstruction / SELinuxMountReadWriteOncePod feature gates
@liggitt liggitt deleted the disable-NewVolumeManagerReconstruction branch July 31, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@dims dims Awaiting requested review from dims

@jsafrane jsafrane Awaiting requested review from jsafrane

@msau42 msau42 Awaiting requested review from msau42

Assignees

@dims dims

@jsafrane jsafrane

@aojea aojea

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@liggitt @dims @k8s-ci-robot @msau42 @jsafrane @k8s-triage-robot @aojea