Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-2876]Add reason and fieldPath into CRD validation rules #118041

Merged
merged 3 commits into from Jul 19, 2023
Merged

[KEP-2876]Add reason and fieldPath into CRD validation rules #118041

merged 3 commits into from Jul 19, 2023

Conversation

cici37
Copy link
Contributor

@cici37 cici37 commented May 16, 2023 •
edited

What type of PR is this?

/kind feature

/kind api-change

What this PR does / why we need it:

Add reason and fieldPath into CRD validation rules

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added fields `reason` and `fieldPath` into CRD validation rules to allow users to specify reason and field path when validation failed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/2876-crd-validation-expression-language

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 16, 2023
@cici37 cici37 added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 16, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 16, 2023
@cici37 cici37 added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 16, 2023
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 16, 2023
@cici37 cici37 added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels May 16, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 16, 2023
@cici37 cici37 removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 16, 2023
@cici37
Copy link
Contributor Author

cici37 commented May 16, 2023

/assign @jpbetz

@cici37 cici37 mentioned this pull request May 16, 2023
Closed
21 tasks
@jpbetz jpbetz mentioned this pull request May 16, 2023
Merged
@k8s-ci-robot k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels May 17, 2023
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@cici37
Copy link
Contributor Author

cici37 commented Jul 19, 2023

@liggitt All comments have been addressed. PTAL when have time. Thank you!

@jpbetz
Copy link
Contributor

jpbetz commented Jul 19, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 11c340466d8631bbbfecac403b2c404946fa9ff0

@liggitt
Copy link
Member

liggitt commented Jul 19, 2023

/approve

for API field additions

/hold
for switching the normalized fieldpath to a string and dropping the SetRoot usage (#118041 (comment))

@jpbetz can lgtm once the impl is updated

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 19, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cici37, jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member

liggitt commented Jul 19, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e38d05fefc480aa22dd48ea566109a3d2fc2f7dd

@liggitt liggitt added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 19, 2023
@jpbetz
Copy link
Contributor

jpbetz commented Jul 19, 2023

/hold cancel
ready to merge now

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit d6e5258 into kubernetes:master Jul 19, 2023
12 checks passed
@cici37 cici37 deleted the addFields branch July 19, 2023 17:08
@pacoxu pacoxu mentioned this pull request Jul 21, 2023
Closed
@liggitt liggitt moved this from In progress to API review completed, 1.28 in API Reviews Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@alexzielenski alexzielenski Awaiting requested review from alexzielenski

@deads2k deads2k Awaiting requested review from deads2k

@jpbetz jpbetz Awaiting requested review from jpbetz

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@jpbetz jpbetz

@liggitt liggitt

@deads2k deads2k

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.28
[sig-release] Bug Triage
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@cici37 @k8s-triage-robot @jiahuif @valaparthvi @dgrisonnet @jpbetz @k8s-ci-robot @liggitt @sttts @deads2k