Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update webhook test code to golang 1.21 #118156

Merged
merged 1 commit into from May 21, 2023
Merged

Update webhook test code to golang 1.21 #118156

merged 1 commit into from May 21, 2023

Conversation

HirazawaUi
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

In Go 1.21, TLS bad certificate errors become more specific and can cause tests to fail

Which issue(s) this PR fixes:

Fixes #118153

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @HirazawaUi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 21, 2023
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 21, 2023
pacoxu
pacoxu approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 955bad30ef1c27a25ff3caee0ceb3167901485d5

@liggitt
Copy link
Member

liggitt commented May 21, 2023

/lgtm
/approve

@liggitt
Copy link
Member

liggitt commented May 21, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, liggitt, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2023
@liggitt liggitt mentioned this pull request May 21, 2023
Closed
36 tasks
@k8s-ci-robot k8s-ci-robot merged commit 1dba84b into kubernetes:master May 21, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 21, 2023
@pacoxu
Copy link
Member

pacoxu commented May 22, 2023

@HirazawaUi could you cherry-pick this PR to old branches v1.24-v1.27?

@HirazawaUi
Copy link
Contributor Author

@HirazawaUi could you cherry-pick this PR to old branches v1.24-v1.27?

Ok, I will do this

This was referenced May 22, 2023
Merged
Merged
Merged
Merged
@cici37
Copy link
Contributor

cici37 commented May 23, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 23, 2023
k8s-ci-robot added a commit that referenced this pull request May 24, 2023
@k8s-ci-robot
Merge pull request #118178 from HirazawaUi/automated-cherry-pick-of-#…
916bc55 
…118156-upstream-release-1.27

Automated cherry pick of #118156: update webhook test to go 1.21
k8s-ci-robot added a commit that referenced this pull request May 24, 2023
@k8s-ci-robot
Merge pull request #118179 from HirazawaUi/automated-cherry-pick-of-#…
64bea24 
…118156-upstream-release-1.26

Automated cherry pick of #118156: update webhook test to go 1.21
k8s-ci-robot added a commit that referenced this pull request May 24, 2023
@k8s-ci-robot
Merge pull request #118180 from HirazawaUi/automated-cherry-pick-of-#…
287b0c2 
…118156-upstream-release-1.25

Automated cherry pick of #118156: update webhook test to go 1.21
k8s-ci-robot added a commit that referenced this pull request May 24, 2023
@k8s-ci-robot
Merge pull request #118181 from HirazawaUi/automated-cherry-pick-of-#…
0ecf088 
…118156-upstream-release-1.24

Automated cherry pick of #118156: update webhook test to go 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@liggitt liggitt

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

apiserver/pkg/util/webhook test needs update for Go 1.21
5 participants
@HirazawaUi @k8s-ci-robot @liggitt @pacoxu @cici37