Dependency update - Golang 1.21.0

[liggitt]

Tracking info

Link to any previous tracking issue: #2815

Golang mailing list announcement:

SIG Release Slack thread: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1687945498281579

Work items for Go1.21rc2

• kube-cross image update: golang: Build 1.21rc2 images #3132

  • image promotion: Image promotion for build-image v1.28.0-go1.21rc2-bullseye.0 k8s.io#5492

• go-runner image update: golang: Build 1.21rc2 images #3132

  • image promotion: Image promotion for build-image v2.3.1-go1.21rc2-bullseye.0 k8s.io#5493

• releng-ci image update: golang: Build 1.21rc2 images #3132

  • image promotion: not promoting this image

Work items for Go1.21rc3

• kube-cross image update: golang: Build 1.21rc3 images #3155

  • image promotion: Image promotion for build-image v1.28.0-go1.21rc3-bookworm.0 k8s.io#5587

• go-runner image update: golang: Build 1.21rc3 images #3155

  • image promotion: Image promotion for build-image v2.3.1-go1.21rc3-bullseye.0 k8s.io#5588

• releng-ci image update: golang: Build 1.21rc3 images #3155

  • image promotion: not promoting this image

Work items for Go1.21

• kube-cross image update: build go1.21 images with base debian bookworm #3212

  • image promotion: Image promotion for build-image v1.28.0-go1.21.0-bookworm.0 k8s.io#5740

• go-runner image update: build go1.21 images with base debian bookworm #3212

  • image promotion: Image promotion for build-image v2.3.1-go1.21.0-bullseye.0 k8s.io#5741

• releng-ci image update: build go1.21 images with base debian bookworm #3212

  • image promotion: Image promotion for releng 1.21.0-bookworm-0 k8s.io#5742

After kube-cross image promotion

• kubernetes/kubernetes update (master): [go] Bump images, dependencies and versions to go 1.21.0 kubernetes#118996

  Ensure the following have been updated within the PR:

  • kube-cross image
  • go-runner image
  • publishing bot rules
  • test image
  • .go-version file

After go-runner image promotion

• debian-iptables image update:

  • image promotion:

• distroless-iptables image update:

  • image promotion:

After distroless-iptables image promotion

• kubernetes/kubernetes update (master):

  Ensure the following have been updated within the PR:

  • distroless-iptables image
  • test image

After kubernetes/kubernetes (master) has been updated

• k8s-cloud-builder image update: add configs for 1.29 and 1.28 for k8s-cloudbuilder and drop 1.24 #3250

• k8s-ci-builder image variants update: update k8s-ci-builder for go1.21 to use bullseye for 1.29 and default for next config keep on bookworm #3251

• kubekins/krte image variants update: Update kubekins-e2e to Go 1.21.0 and drop config for k8s 1.24 test-infra#30631

Follow-up items

• Ensure the Golang issue template is updated with any new requirements

/assign
cc: @kubernetes/release-engineering

[liggitt]

Tracking PRs related to go1.21 that we would need to pick to release branches as part of an eventual update to go1.20:

• kubeadm: remove function pointer comparison in phase test kubernetes#118150
  • 1.27: Automated cherry pick of #118150 origin release 1.27 kubernetes#119086
  • 1.26: Automated cherry pick of #118150: kubeadm: remove function pointer comparison in phase test kubernetes#118168
  • 1.25: Automated cherry pick of #118150: kubeadm: remove function pointer comparison in phase test kubernetes#118167
  • 1.24: Automated cherry pick of #118150: kubeadm: remove function pointer comparison in phase test kubernetes#118166
• Update webhook test code to golang 1.21 kubernetes#118156
  • 1.27: Automated cherry pick of #118156: update webhook test to go 1.21 kubernetes#118178
  • 1.26: Automated cherry pick of #118156: update webhook test to go 1.21 kubernetes#118179
  • 1.25: Automated cherry pick of #118156: update webhook test to go 1.21 kubernetes#118180
  • 1.24: Automated cherry pick of #118156: update webhook test to go 1.21 kubernetes#118181
• Fix the git-repo test error caused by the correct use of loop variables kubernetes#118177
  • 1.27: Automated cherry pick of #118177: Fix the git-repo test error caused by the correct use of loop kubernetes#118290
  • 1.26: Automated cherry pick of #118177: Fix the git-repo test error caused by the correct use of loop kubernetes#118289
  • 1.25: Automated cherry pick of #118177: Fix the git-repo test error caused by the correct use of loop kubernetes#118288
  • 1.24: Automated cherry pick of #118177: Fix the git-repo test error caused by the correct use of loop kubernetes#118287
• dra scheduler plugin test: fix loopvar bug and "reserve" expected data kubernetes#118257
  • 1.27: Automated cherry pick of #118257: dra scheduler plugin test: fix loopvar bug and "reserve" kubernetes#118283
  • 1.26: Automated cherry pick of #118257: dra scheduler plugin test: fix loopvar bug and "reserve" kubernetes#118284
  • 1.25: n/a
  • 1.24: n/a
• golangci-lint update and support for Go 1.21 kubernetes#119860
  • 1.28: Automated cherry pick of #119860: update to golangci-lint v1.54.1 + go-ruleguard v0.4.0 kubernetes#119999
  • 1.27: Automated cherry pick of #119860: update to golangci-lint v1.54.1 + go-ruleguard v0.4.0 kubernetes#119997
  • 1.26: Automated cherry pick of #119860: update to golangci-lint v1.54.1 + go-ruleguard v0.4.0 kubernetes#119996
  • 1.25: Automated cherry pick of #119860: update to golangci-lint v1.54.1 + go-ruleguard v0.4.0 kubernetes#119995
  • 1.24: EOL, not picked
• [prep for go1.21]: use -e in go list kubernetes#119027
  • 1.28: [1.28] Automated cherry pick of #119027: prep for go1.21: use -e in go list kubernetes#120037
  • 1.27: [1.27] Automated cherry pick of #119027: prep for go1.21: use -e in go list kubernetes#120036
  • 1.26: [1.26] Automated cherry pick of #119027: prep for go1.21: use -e in go list kubernetes#120035
  • 1.25: [1.25] Automated cherry pick of #119027: prep for go1.21: use -e in go list kubernetes#120034
  • 1.24: EOL, not picked
• handle GOTOOLCHAIN in kube::golang::verify_go_version kubernetes#120279
  • 1.28: Cherry pick handle #120279 GOTOOLCHAIN in kube::golang::verify_go_version onto 1.28 kubernetes#122075
  • 1.27: Cherry pick handle #120279 GOTOOLCHAIN in kube::golang::verify_go_version onto 1.27  kubernetes#122076
  • 1.26: Cherry pick handle #120279 GOTOOLCHAIN in kube::golang::verify_go_version onto 1.26 kubernetes#122077
  • 1.25: EOL, not picked

---

Tracking verification of conditions for bumping go1.21 on release branches:

• ~2023-11-01: 3 months after go 1.21 release (ETA 2023-08-01)
• ~2024-01-15: 1 month after Kubernetes 1.29 release on go1.21 (ETA 2023-12-15)
• no regressions relative to go 1.20 known to impact Kubernetes: there are no regressions that are fixed in go1.21.7 (yet to be released and consumed by Kubernetes) that are known to impact Kubernetes (ref)
• pass unit and integration tests with both go 1.21 and the original go version for the release branch
  • 1.26: demonstrated in: [prep go1.21 bump] Test 1.26 release branch with go1.21 kubernetes#122783
  • 1.27: demonstrated in: [prep go1.21 bump] Test 1.27 release branch with go1.21 kubernetes#122784
  • 1.28: demonstrated in: [prep go1.21 bump] Test 1.28 release branch with go1.21 kubernetes#122785
• any behavior changes in go 1.21 are mitigated to preserve existing behavior without requiring action by Kubernetes end-users
  • 1.26: NA
  • 1.27: NA
  • 1.28: NA

---

Tracking the PR that actually bumps to go1.21:

• • 1.26: [release-1.26] [go] Bump images, dependencies and versions to go 1.21.7 / distroless-iptables to v0.4.5 kubernetes#123230
  • 1.27: [release-1.27] [go] Bump images, dependencies and versions to go 1.21.7 / distroless-iptables to v0.4.5 kubernetes#123229
  • 1.28: [release-1.28] [go] Bump images, dependencies and versions to go 1.21.7 / setcap/debian-base to bookworm-v1.0.1 and distroless-iptables to v0.4.5 kubernetes#123228

[rsc]

Also the PR for kubernetes/kubernetes#118153 (don't think there is one yet but I pasted the patch in the report).

[aojea]

/cc

[cpanato]

/assign will help here as well

[neolit123]

@cpanato please help approve the open (green) cherry picks mentioned here:
#3076 (comment)

[neolit123]

1.27: kubernetes/kubernetes#118169

was repaced with kubernetes/kubernetes#119086

[BenTheElder]

xref: kubernetes/kubernetes#120279 (shim existing go toolchain management to GOTOOLCHAIN)

[dims]

cc @danbudris @zafs23

[liggitt]

changes lgtm, prereqs are met, I think we can go ahead and do the release branch bumps for real

[cpanato]

Cool, i will start the process

[humblec]

@cpanato will we complete the bump to 1.21.7 in k8s release <= v1.28 and make it ready for Feb patches?

[cpanato]

@cpanato will we complete the bump to 1.21.7 in k8s release <= v1.28 and make it ready for Feb patches?

this is on going right now :)

[liggitt]

updated in https://github.com/kubernetes/kubernetes/pulls?q=is%3Apr+%22go+1.21.7%22+is%3Amerged+-base%3Amaster

added links to #3076 (comment)

/close
as completed

[k8s-ci-robot]

@liggitt: Closing this issue.

In response to this:

updated in https://github.com/kubernetes/kubernetes/pulls?q=is%3Apr+%22go+1.21.7%22+is%3Amerged+-base%3Amaster

added links to #3076 (comment)

/close
as completed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.