kubelet: fix comment typo

[champly]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

[k8s-ci-robot]

Welcome @champly!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @champly. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bart0sh]

Thank you for your PR. It seems to only contain trivial edits. Please
read our trivial edits policy.

[champly]

Thank you for your PR. It seems to only contain trivial edits. Please read our trivial edits policy.

This pr is only in:

• cmd/kubelet/app/server.go
• pkg/kubelet/cm/cgroup_manager_test.go

used in two files, only related description in cmd/kubelet/app/server.go file:

experimentalQOSReserved, err := cm.ParseQOSReserved(s.QOSReserved)
if err != nil {
	return fmt.Errorf("--qos-reserved value failed to parse: %w", err)
}

[bart0sh]

/ok-to-test
/triage accepted
/priority important-longterm
/king cleanup

[bart0sh]

/kind cleanup

[bart0sh]

@champly

experimentalQOSReserved, err := cm.ParseQOSReserved(s.QOSReserved)
if err != nil {
	return fmt.Errorf("--qos-reserved value failed to parse: %w", err)
}

Why parsing of alpha future command line option is not wrapped into a feature gate check?

[bart0sh]

/assign @sjenning

[champly]

@champly

experimentalQOSReserved, err := cm.ParseQOSReserved(s.QOSReserved)
if err != nil {
	return fmt.Errorf("--qos-reserved value failed to parse: %w", err)
}

Why parsing of alpha future command line option is not wrapped into a feature gate check?

Need to add feature gate check? like this:

var experimentalQOSReserved *map[v1.ResourceName]int64
if utilfeature.DefaultFeatureGate.Enabled(features.QOSReserved) {
	experimentalQOSReserved, err = cm.ParseQOSReserved(s.QOSReserved)
	if err != nil {
		return fmt.Errorf("--qos-reserved value failed to parse: %w", err)
	}
}

I'm not sure if there will be any other problems with this modification.

[bart0sh]

I'm not sure if there will be any other problems with this modification.

let's see what other reviewers and especially @sjenning say about it.

[bart0sh]

/retest

[bart0sh]

/test pull-kubernetes-e2e-kind-ipv6

[bart0sh]

/cc

[bart0sh]

/lgtm

[bart0sh]

/assign @mrunalp @derekwaynecarr @dchen1107

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 5397f6db70485470e08cc8c375d86ea837d92c49

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: champly, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/cm/OWNERS [mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment