New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix update-vendor.sh logging #118187
Fix update-vendor.sh logging #118187
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple questions, but seems fine... ran before/after locally and normal output looked identical and normal log content looked ~identical
e235bca
to
7731a7c
Compare
Re-pushed. The failure I was chasing now logs properly. |
Previously it would corrupt the log when it ran stuff like: go mod tidy >> "${LOG_FILE}" 2>&1 because this would reopen the file. Also, if that failed, the `finish` function would be called ALSO with output to the log. Now we let &1 and &2 always be the log, and &11 and &22 are the real stdout/stderr, which means we have to say that explicitly when we want output. No, I cannot do `OUT="&11"` - I would have to use `eval` to make that work.
7731a7c
to
ece68cf
Compare
/sig architecture |
LGTM label has been added. Git tree hash: 1a0ac67de3af920d389322d009ad8ad13e0956c0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Previously it would corrupt the log when it ran stuff like:
go mod tidy >> "${LOG_FILE}" 2>&1
because this would reopen the file. Also, if that failed, the
finish
function would be called ALSO with output to the log.Now we let &1 and &2 always be the log, and &11 and &22 are the real stdout/stderr, which means we have to say that explicitly when we want output.
No, I cannot do
OUT="&11"
- I would have to useeval
to make that work./kind bug
/kind cleanup