Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update-vendor.sh logging #118187

Merged

Commits on May 22, 2023

  1. Fix update-vendor.sh logging

    Previously it would corrupt the log when it ran stuff like:
        go mod tidy >> "${LOG_FILE}" 2>&1
    because this would reopen the file.  Also, if that failed, the `finish`
    function would be called ALSO with output to the log.
    
    Now we let &1 and &2 always be the log, and &11 and &22 are the real
    stdout/stderr, which means we have to say that explicitly when we want
    output.
    
    No, I cannot do `OUT="&11"` - I would have to use `eval` to make that
    work.
    thockin committed May 22, 2023
    Configuration menu
    Copy the full SHA
    ece68cf View commit details
    Browse the repository at this point in the history