Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #115966: make MixedProtocolNotSupported public #118252

Merged
merged 2 commits into from Jul 12, 2023
Merged

Automated cherry pick of #115966: make MixedProtocolNotSupported public #118252

merged 2 commits into from Jul 12, 2023

Conversation

aojea
Copy link
Member

@aojea aojea commented May 25, 2023

Cherry pick of #115966 on release-1.26.

#115966: make MixedProtocolNotSupported public

For details on the cherry pick process, see the cherry pick requests page.

aojea added 2 commits May 25, 2023 08:24
@aojea
make MixedProtocolNotSupported public
32ff319 
Change-Id: Ib9f5ea8e36c831cd0e9649aa998c96f61d56122d
@aojea
don't process unsupported loadbalancers with mixed protocols
6300196 
Mixed protocols were not supported in GCE loadbalancers for old
versions, so we should fail to avoid confusions on users.

Ref: k8s.io/cloud-provider-gcp#475
Change-Id: I5fbd5230afbc51d595cacc96b3fa86473a3eb131
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone May 25, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 25, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 25, 2023
@aojea aojea force-pushed the automated-cherry-pick-of-#115966-upstream-release-1.26 branch from 09c5f48 to 6300196 Compare May 25, 2023 08:25
@aojea
Copy link
Member Author

aojea commented May 25, 2023

/kind bug
/sig cloud-provider

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 25, 2023
@k8s-ci-robot k8s-ci-robot added area/cloudprovider kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels May 25, 2023
@aojea aojea mentioned this pull request May 25, 2023
Merged
@aojea
Copy link
Member Author

aojea commented May 25, 2023

k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/admission/plugin/validatingadmissionpolicy/internal/generic: TestShutdown expand_less

/test pull-kubernetes-unit

@aojea
Copy link
Member Author

aojea commented May 25, 2023

/assign @cpanato @cheftako @nckturner

@thockin
Copy link
Member

thockin commented Jun 6, 2023

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b881880f59e827fece8e33fba2d40a898301cc8c

@thockin
Copy link
Member

thockin commented Jul 7, 2023

ping @kubernetes/release-managers

@jeremyrickard
Copy link
Contributor

Does this one only need to go to 1.26? I don't see an open cherry pick for other branches and wanted to follow up on that before we approve this.

@thockin
Copy link
Member

thockin commented Jul 7, 2023 via email

@jeremyrickard
Copy link
Contributor

I pinged 3 today. #118252 #116669 #116668
…

oops, I missed the others. apologies!

@jeremyrickard jeremyrickard added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 7, 2023
@thockin
Copy link
Member

thockin commented Jul 11, 2023

Still needs approval from @cheftak

@cheftako
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, cheftako, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit e48d6e1 into kubernetes:release-1.26 Jul 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako Awaiting requested review from cheftako

@sttts sttts Awaiting requested review from sttts

Assignees

@cheftako cheftako

@nckturner nckturner

@cpanato cpanato

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@aojea @k8s-ci-robot @thockin @jeremyrickard @cheftako @nckturner @cpanato