Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #115966: make MixedProtocolNotSupported public #116669

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Automated cherry pick of #115966: make MixedProtocolNotSupported public #116669

merged 3 commits into from
Jul 7, 2023

Conversation

aojea
Copy link
Member

@aojea aojea commented Mar 15, 2023 •
edited

Cherry pick of #115966 on release-1.24.

#115966: don't process unsupported loadbalancers with mixed protocols #115966

For details on the cherry pick process, see the cherry pick requests page.

NONE

@aojea
make MixedProtocolNotSupported public
da1a773 
Change-Id: Ib9f5ea8e36c831cd0e9649aa998c96f61d56122d
@aojea
don't process unsupported loadbalancers with mixed protocols
f7cce14 
Mixed protocols were not supported in GCE loadbalancers for old
versions, so we should fail to avoid confusions on users.

Ref: k8s.io/cloud-provider-gcp#475
Change-Id: I5fbd5230afbc51d595cacc96b3fa86473a3eb131
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added area/cloudprovider kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 15, 2023
@aojea
Copy link
Member Author

aojea commented Mar 15, 2023

/kind bug
/sig network
/sig cloud-provider
/assign @thockin @andrewsykim @bowei @liggitt

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Mar 15, 2023
@thockin
Copy link
Member

thockin commented Mar 15, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2023
@aojea aojea force-pushed the automated-cherry-pick-of-#115966-upstream-release-1.24 branch from 7a214ac to a22fdb1 Compare March 24, 2023 22:20
@thockin
Copy link
Member

thockin commented Apr 14, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 795f2cf50840bf0e26d0af609670149493aa8551

@cheftako
Copy link
Member

cheftako commented May 9, 2023

/lgtm

@cheftako
Copy link
Member

cheftako commented May 9, 2023

/assign @nckturner

elmiko
elmiko reviewed May 13, 2023
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cheftako
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, cheftako, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2023
@aojea aojea mentioned this pull request May 18, 2023
Closed
@aojea
Copy link
Member Author

aojea commented May 18, 2023

ping @kubernetes/release-managers

it seems it slipped through 🤷

@cpanato
Copy link
Member

cpanato commented May 19, 2023

@aojea the CP is only required for 1.24 and 1.25?

@aojea
Copy link
Member Author

aojea commented May 19, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2023
@aojea
Copy link
Member Author

aojea commented May 19, 2023

@aojea the CP is only required for 1.24 and 1.25?

no, I just realized that the 1.26 is missing, I thought the original PR merged in 1.26 but it was in 1.27, let me go thhrought all of them again

Thanks Carlos for realizing about this

@cpanato
Copy link
Member

cpanato commented May 19, 2023

@aojea the CP is only required for 1.24 and 1.25?

no, I just realized that the 1.26 is missing, I thought the original PR merged in 1.26 but it was in 1.27, let me go thhrought all of them again

Thanks Carlos for realizing about this

thank you, please ping me when is all ready :) have a great weekend

@aojea
Copy link
Member Author

aojea commented May 25, 2023

thank you, please ping me when is all ready :) have a great weekend

#118252

@aojea
Copy link
Member Author

aojea commented May 25, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2023
@bridgetkromhout
Copy link
Member

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team June 6, 2023 16:31
@thockin
Copy link
Member

thockin commented Jul 7, 2023

ping @kubernetes/release-managers

@thockin thockin mentioned this pull request Jul 7, 2023
Merged
@jeremyrickard jeremyrickard added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9cdbbcb into kubernetes:release-1.24 Jul 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@soltysh soltysh Awaiting requested review from soltysh

@bowei bowei Awaiting requested review from bowei

@liggitt liggitt Awaiting requested review from liggitt

@thockin thockin Awaiting requested review from thockin

Assignees

@elmiko elmiko

@bowei bowei

@cheftako cheftako

@liggitt liggitt

@nckturner nckturner

@thockin thockin

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet