Set the node-ips annotation correctly with CloudDualStackNodeIPs

[danwinship]

What type of PR is this?

/kind bug
/kind feature

What this PR does / why we need it:

Fixes CloudDualStackNodeIPs; we were not actually setting the annotation correctly when using dual-stack node IPs. Doh. (The original version of the code involved totally-rewritten annotation-setting code because it also added a new annotation. When I removed that I forgot to add in the new simpler annotation-setting code...)

Which issue(s) this PR fixes:

Fixes #118315

Special notes for your reviewer:

(The new code doesn't need to check the feature gate because we know that the only way there can be 2 nodeIPs is if the config parsing code saw that the feature gate was set.)

Does this PR introduce a user-facing change?

Fixes the alpha `CloudDualStackNodeIPs` feature.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/3705

/sig network
/priority important-soon
/cc @aojea @MaysaMacedo

[k8s-ci-robot]

@danwinship: GitHub didn't allow me to request PR reviews from the following users: MaysaMacedo.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind bug
/kind feature

What this PR does / why we need it:

Fixes CloudDualStackNodeIPs; we were not actually setting the annotation correctly when using dual-stack node IPs. Doh. (The original version of the code involved totally-rewritten annotation-setting code because it also added a new annotation. When I removed that I forgot to add in the new simpler annotation-setting code...)

Which issue(s) this PR fixes:

Fixes #118315

Special notes for your reviewer:

(The new code doesn't need to check the feature gate because we know that the only way there can be 2 nodeIPs is if the config parsing code saw that the feature gate was set.)

Does this PR introduce a user-facing change?

Fixes the alpha `CloudDualStackNodeIPs` feature.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/3705

/sig network
/priority important-soon
/cc @aojea @MaysaMacedo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danwinship]

/retest
/assign @thockin

[aojea]

/lgtm
/approve

/assign @thockin

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 505d9b56bac4bb721fbd7eae342cd915acd6e9db

[MaysaMacedo]

Looks good to me.

[bart0sh]

/triage accepted

[thockin]

Thanks!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, danwinship, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@danwinship: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-e2e-gce	a6c7f63	link	unknown	/test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dims]

/retest

[mkowalski]

Hey folks, is it okay if we cherry-pick it to release-1.27 branch?