Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check before you sudo on AWS EC2 instances #118628

Merged
merged 1 commit into from Jun 14, 2023
Merged

check before you sudo on AWS EC2 instances #118628

merged 1 commit into from Jun 14, 2023

Conversation

dims
Copy link
Member

@dims dims commented Jun 12, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We have a check for GCE/GCP environment to skip sudo verification step, let's do the same for AWS as well using metadata ip address.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 12, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 12, 2023
@dims
Copy link
Member Author

dims commented Jun 12, 2023

/test pull-kubernetes-node-e2e-containerd-ec2

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@dims
Copy link
Member Author

dims commented Jun 12, 2023

/test pull-kubernetes-node-e2e-containerd-ec2

@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 12, 2023
@upodroid
Copy link
Member

Interesting error

@upodroid
Copy link
Member

/test pull-kubernetes-node-e2e-containerd-ec2

7 similar comments
@upodroid
Copy link
Member

/test pull-kubernetes-node-e2e-containerd-ec2

@upodroid
Copy link
Member

/test pull-kubernetes-node-e2e-containerd-ec2

@upodroid
Copy link
Member

/test pull-kubernetes-node-e2e-containerd-ec2

@upodroid
Copy link
Member

/test pull-kubernetes-node-e2e-containerd-ec2

@upodroid
Copy link
Member

/test pull-kubernetes-node-e2e-containerd-ec2

@upodroid
Copy link
Member

/test pull-kubernetes-node-e2e-containerd-ec2

@upodroid
Copy link
Member

/test pull-kubernetes-node-e2e-containerd-ec2

@SergeyKanzhelev
Copy link
Member

@dims is it still WIP? Looks like a straightforward fix.

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs Waiting on Author in SIG Node CI/Test Board Jun 14, 2023
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to WIP in SIG Node PR Triage Jun 14, 2023
@upodroid upodroid mentioned this pull request Jun 14, 2023
Merged
@dims
check for AWS environment before running sudo
89adbc6 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 14, 2023
@dims dims changed the title [WIP] check before you sudo check before you sudo on AWS EC2 instances Jun 14, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2023
@dims
Copy link
Member Author

dims commented Jun 14, 2023

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 14, 2023
@dims
Copy link
Member Author

dims commented Jun 14, 2023

/test pull-kubernetes-node-e2e-containerd-ec2

@dims
Copy link
Member Author

dims commented Jun 14, 2023

@dims is it still WIP? Looks like a straightforward fix.

Refreshed this with just the ping for metadata ip @SergeyKanzhelev we can merge once this is green. I kicked off the ec2 CI job as well.

@upodroid
Copy link
Member

upodroid commented Jun 14, 2023 •
edited

btw, the ec2 CI job is falsely reporting green

@upodroid
Copy link
Member

/test pull-kubernetes-node-e2e-containerd-ec2

upodroid
upodroid approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2591aaf17be4d9dcdccee0a2d0e18d120a2ab41e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e436472 into kubernetes:master Jun 14, 2023
13 checks passed
SIG Node CI/Test Board automation moved this from PRs Waiting on Author to Done Jun 14, 2023
SIG Node PR Triage automation moved this from WIP to Done Jun 14, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@thockin thockin Awaiting requested review from thockin

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Status: Done
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dims @k8s-ci-robot @upodroid @SergeyKanzhelev