Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quantity library to CEL #118803

Merged
merged 23 commits into from Jul 13, 2023
Merged

Add quantity library to CEL #118803

merged 23 commits into from Jul 13, 2023

Conversation

alexzielenski
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds some helper functions for dealing with resource.Quantity to the CEL library.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

New CEL Library functions to support Kubernetes Quantities.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig api-machinery
/cc @jpbetz

@k8s-ci-robot k8s-ci-robot requested a review from jpbetz June 21, 2023 17:41
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver labels Jun 21, 2023
@jiahuif
Copy link
Member

jiahuif commented Jul 5, 2023

/assign

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2023
@benluddy
Copy link
Contributor

/assign

@alexzielenski
Copy link
Contributor Author

/retest

@benluddy
Copy link
Contributor

/lgtm

Do you want to squash these commits?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 736d50f3e3ccf441fec2d791b95c9aae21840ca7

@jiahuif
Copy link
Member

jiahuif commented Jul 13, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 13, 2023
@alexzielenski
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@cici37
Copy link
Contributor

cici37 commented Jul 13, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 367aecb72319df11f181795ffa631d27006964ca

@cici37
Copy link
Contributor

cici37 commented Jul 13, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski, cici37

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 423f4df into kubernetes:master Jul 13, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 13, 2023
@cici37 cici37 mentioned this pull request Jul 17, 2023
Open
16 tasks
@sftim
Copy link
Contributor

sftim commented Jul 19, 2023

Retrospective suggestion for the changelog entry

Added some CEL library functions to support Kubernetes [Quantities](https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/quantity/).

@alexzielenski alexzielenski mentioned this pull request Jul 20, 2023
Merged
43 tasks
@alexzielenski alexzielenski mentioned this pull request Aug 8, 2023
Closed
@matheusfm matheusfm mentioned this pull request Sep 4, 2023
Merged
3 tasks
@jpbetz jpbetz mentioned this pull request Apr 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz left review comments

@cici37 cici37 cici37 left review comments

@benluddy benluddy Awaiting requested review from benluddy

@jiahuif jiahuif Awaiting requested review from jiahuif

Assignees

@benluddy benluddy

@jiahuif jiahuif

@cici37 cici37

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alexzielenski @jiahuif @benluddy @k8s-ci-robot @cici37 @sftim @jpbetz