Exclude terminal pods from Daemonset e2e tests #118935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-priority
|
/test |
|
@aojea: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-e2e-gce-serial This job should exercise the test IIRC |
|
it runs in this job, is that the job takes 3 hours 🐢 🙃 |
alculquicondor
force-pushed
the
fix-conformance
branch
from
2af8052
to
9bcdf26
Compare
k8s-ci-robot
added
size/S
|
/test pull-kubernetes-e2e-gce-serial |
Change-Id: Ic29ca1739ebdc54822d1751fcd56a99c628021c4
alculquicondor
force-pushed
the
fix-conformance
branch
from
9bcdf26
to
60fb8f2
Compare
|
/test pull-kubernetes-e2e-gce-serial |
are we good to go @alculquicondor ? |
|
yes |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d0b89a78b54fb3a13886928d3974db83f9a2148f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@alculquicondor we should wait some time before moving forward with the cherry-picks https://testgrid.k8s.io/sig-network-kind#sig-network-kind,%20IPv6,%20master 3 consecutive greens sounds good enough to me |
|
Agreed :) |
|
No test has run with the change yet |
This was referenced Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind flake
What this PR does / why we need it:
Terminal pods will not be restarted, so they can be excluded from calculations.
Starting from k8s 1.27, kubelet transitions every pod to a terminal phase (Failed, Succeeded) before deleting it from the store.
Which issue(s) this PR fixes:
Fixes #118928
Special notes for your reviewer:
This is a follow up to #118716
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: