Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go] Bump images, dependencies and versions to go 1.21.0 #118996

Merged
merged 2 commits into from
Sep 6, 2023
Merged

[go] Bump images, dependencies and versions to go 1.21.0 #118996

merged 2 commits into from
Sep 6, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jun 30, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Bump images, dependencies and versions to go 1.21.0

Which issue(s) this PR fixes:

Part of kubernetes/release#3076

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with go 1.21.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 30, 2023
@cpanato
Copy link
Member Author

cpanato commented Jun 30, 2023

cc @liggitt @ameukam

@MadhavJivrajani
Copy link
Contributor

cc @akhilerm

@MadhavJivrajani
Copy link
Contributor

/assign

@MadhavJivrajani
Copy link
Contributor

MadhavJivrajani commented Jul 3, 2023 •
edited

From pull-kubernetes-dependencies

go: found k8s.io/code-generator in k8s.io/code-generator v0.0.0-00010101000000-000000000000
../code-generator/tools.go:25:2: import "k8s.io/code-generator/cmd/applyconfiguration-gen" is a program, not an importable package

A smaller reproducer of this is to run the following in root of k/k:

go list -tags=tools all

On running this, I get:

❯ go list -tags=tools all
build/tools.go:25:2: import "github.com/onsi/ginkgo/v2/ginkgo" is a program, not an importable package

Seems like this is tracked here: golang/go#59186
Trying a workaround.

This was referenced Jul 3, 2023
Merged
Merged
Open
This was referenced Jul 3, 2023
Closed
Closed
@MadhavJivrajani
Copy link
Contributor

Tracking issue and WIP PR for go1.21 support for golangci-lint:

Thread on gophers slack with the golangci-lint maintainer: https://gophers.slack.com/archives/CS0TBRKPC/p1688365821502669?thread_ts=1686144370.506279&cid=CS0TBRKPC

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2023
@cpanato cpanato changed the title WIP [go] Bump images, dependencies and versions to go 1.21rc2 WIP [go] Bump images, dependencies and versions to go 1.21rc3 Jul 20, 2023
@saschagrunert saschagrunert mentioned this pull request Sep 6, 2023
Merged
@cpanato
Bump images, dependencies and versions to go 1.21.0
67858e1 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
move back to bullseye
9c1df5f 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Member Author

cpanato commented Sep 6, 2023

move back to bullseye the kube-cross

cc @liggitt @saschagrunert

@pacoxu
Copy link
Member

pacoxu commented Sep 6, 2023

/priority important-soon
/unhold

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, liggitt, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member

pacoxu commented Sep 6, 2023

/lgtm
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 6, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 90c7dd82fa6ee6f6bc8a9a19fede149f889658fe

@cpanato
Copy link
Member Author

cpanato commented Sep 6, 2023

/hold for final comments/reviews from @liggitt

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2023
@cpanato
Copy link
Member Author

cpanato commented Sep 6, 2023

i saw that @pacoxu unhold so will lift

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8703ca2 into kubernetes:master Sep 6, 2023
16 of 17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 6, 2023
@cpanato cpanato deleted the golang121 branch September 6, 2023 12:49
@cpanato cpanato mentioned this pull request Sep 6, 2023
Closed
36 tasks
@BenTheElder
Copy link
Member

xref: #120279

@pacoxu pacoxu mentioned this pull request Sep 12, 2023
Closed
@dusk125 dusk125 mentioned this pull request Sep 12, 2023
Closed
5 tasks
@mimowo mimowo mentioned this pull request Sep 25, 2023
Merged
@pacoxu pacoxu mentioned this pull request Jan 25, 2024
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@liggitt liggitt Awaiting requested review from liggitt

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

Assignees

@liggitt liggitt

@pacoxu pacoxu

@MadhavJivrajani MadhavJivrajani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cpanato @MadhavJivrajani @saschagrunert @liggitt @k8s-ci-robot @pacoxu @BenTheElder