Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e_node: stop using deprecated framework.ExpectEqual #119501

Merged
merged 1 commit into from Aug 16, 2023
Merged

e2e_node: stop using deprecated framework.ExpectEqual #119501

merged 1 commit into from Aug 16, 2023

Conversation

Songjoy
Copy link
Contributor

@Songjoy Songjoy commented Jul 21, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

e2e_node: stop using deprecated framework.ExpectEqual

Which issue(s) this PR fixes:

Ref #115961

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 21, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Songjoy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 21, 2023
@carlory
Copy link
Member

carlory commented Jul 21, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 21, 2023
@yxxhero
Copy link
Member

yxxhero commented Jul 22, 2023

/retest-required

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Jul 23, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Jul 24, 2023

/retest

@bart0sh
Copy link
Contributor

bart0sh commented Jul 24, 2023

/triage accepted
/priority important-longterm
/assign @pohly

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 24, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Jul 24, 2023
@Songjoy
Copy link
Contributor Author

Songjoy commented Jul 25, 2023

/retest

@Songjoy Songjoy force-pushed the cleanup-e2e-node-framework-equal branch from a822f31 to 8e35db7 Compare July 25, 2023 11:10
@Songjoy Songjoy force-pushed the cleanup-e2e-node-framework-equal branch from 8e35db7 to 63cf568 Compare July 26, 2023 02:20
@liangyuanpeng liangyuanpeng mentioned this pull request Jul 26, 2023
Merged
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Jul 26, 2023
swatisehgal
swatisehgal reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3c57f702070d666503098018d070d73683218461

@swatisehgal swatisehgal moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Jul 31, 2023
@swatisehgal swatisehgal moved this from PRs - Needs Reviewer to PRs - Needs Approver in SIG Node CI/Test Board Jul 31, 2023
@swatisehgal
Copy link
Contributor

/assign @SergeyKanzhelev
for approval

SergeyKanzhelev
SergeyKanzhelev approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SergeyKanzhelev, Songjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9ee7185 into kubernetes:master Aug 16, 2023
3 of 13 checks passed
SIG Node CI/Test Board automation moved this from PRs - Needs Approver to Done Aug 16, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Aug 16, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Aug 16, 2023
@Songjoy Songjoy mentioned this pull request Sep 7, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatisehgal swatisehgal swatisehgal left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@pohly pohly

@SergeyKanzhelev SergeyKanzhelev

@swatisehgal swatisehgal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Status: Done
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Songjoy @k8s-ci-robot @carlory @yxxhero @bart0sh @swatisehgal @SergeyKanzhelev @pohly