e2e_storage: stop using deprecated framework.ExpectEqual

[Songjoy]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

e2e_storage: stop using deprecated framework.ExpectEqual

Which issue(s) this PR fixes:

Ref #115961

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @Songjoy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[liangyuanpeng]

I can see that you're created much PR for it:

• e2e_node: stop using deprecated framework.ExpectEqual #119501
• e2e_windows: stop using deprecated framework.ExpectEqual #119463
• e2e_upgrades: stop using deprecated framework.ExpectEqual #119468
• e2e_scheduling: stop using deprecated framework.ExpectEqual #119502

Thanks for your work and i'm really create a PR before this PR (even draft status):

• e2e_storage: stop using deprecated framework.ExpectEqual #119552

This issue great for my upfront contribution, I'd like to work on it, could you make it up to me? Thanks.

@Songjoy

[carlory]

Thanks for your contribution! @liangyuanpeng. @Songjoy has do a lot of work on this task. There're lots of similar issues in the codebase. This link https://github.com/kubernetes/kubernetes/pull/119490/files#diff-f269a9e91aa6759831e67c7826ff093fa867167326f0b2c4a79967f54c126b86R649 is example about how to cleanup framework.ExpectNotEqual.

Could you help me to cleanup other e2e tests in another prs. It's good first issue for new contributors. What do you think? If you want to continue to work on #119552, I think it's also ok and welcomed.

[Songjoy]

If you want to continue to work on #119552, I think it's also ok and welcomed. And I will close this PR.
@liangyuanpeng

[carlory]

/ok-to-test

[Songjoy]

/assign @chrishenzie

[Songjoy]

/test pull-kubernetes-node-e2e-containerd

[carlory]

/lgtm

/assign @pohly

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 9edd285f6860cfbf9e1cb7013f07f7cc0ee3be3a

[pohly]

@Songjoy thanks for the PR and thanks @carlory for the review and suggestions.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, Songjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/e2e/storage/OWNERS [pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment