Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos in kubelet component source code #119754

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Fix some typos in kubelet component source code #119754

merged 1 commit into from
Sep 10, 2023

Conversation

pbxqdown
Copy link
Contributor

@pbxqdown pbxqdown commented Aug 4, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The PR fixes several grammar/spell typos in kubelet component source code.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

My first PR, hope it helps a little ;)

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.28 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.28.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 4 04:28:37 UTC 2023.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from dims August 4, 2023 07:11
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @pbxqdown!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @pbxqdown. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 4, 2023
@bart0sh bart0sh added this to Done in SIG Node PR Triage Aug 4, 2023
@bart0sh bart0sh moved this from Done to Triage in SIG Node PR Triage Aug 4, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Aug 6, 2023

/ok-to-test
/triage accepted
/priority backlog
/lgtm
/assign @SergeyKanzhelev @mrunalp @derekwaynecarr @dchen1107

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 6, 2023
@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Aug 6, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 6, 2023
@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 6, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 12945d1a02883a499196db3079957af50242d191

@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Aug 6, 2023
@pbxqdown
Copy link
Contributor Author

pbxqdown commented Aug 6, 2023

/retest

@pbxqdown
Copy link
Contributor Author

pbxqdown commented Aug 6, 2023

pull-kubernetes-node-e2e-containerd failure is caused by flaky OOMKiller test(described in #119600).

pull-kubernetes-e2e-kind-ipv6 Kubernetes e2e suite: [It] [sig-api-machinery] AdmissionWebhook [Privileged:ClusterAdmin] seems another flaky test.

@pbxqdown pbxqdown mentioned this pull request Aug 6, 2023
Closed
@iholder101
Copy link
Contributor

/lgtm

@pbxqdown
Copy link
Contributor Author

@mrunalp @bart0sh @iholder101 wondering whether this PR is mergeable. saw a pending check saying must be in milestone v1.28.

@SergeyKanzhelev
Copy link
Member

@mrunalp @bart0sh @iholder101 wondering whether this PR is mergeable. saw a pending check saying must be in milestone v1.28.

Branch will open for 1.29 soon - once 1.28 is released. We are in test freeze now

@pbxqdown
Copy link
Contributor Author

Got it, thanks for clarification on the release workflow.

@pbxqdown
Copy link
Contributor Author

hey folks, need approved label for this MR. I think release 1.28 has already rolled out?

@pbxqdown
Copy link
Contributor Author

pbxqdown commented Sep 3, 2023

@SergeyKanzhelev could you please approve the PR🙏

@pbxqdown
Copy link
Contributor Author

@dims @yujuhong could you please approve the PR🙏

@dims
Copy link
Member

dims commented Sep 10, 2023

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pbxqdown

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4976813 into kubernetes:master Sep 10, 2023
12 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Sep 10, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@dims dims

@mrunalp mrunalp

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

@iholder101 iholder101

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@pbxqdown @k8s-ci-robot @bart0sh @iholder101 @SergeyKanzhelev @dims @mrunalp @derekwaynecarr @dchen1107