Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #119860: update to golangci-lint v1.54.1 + go-ruleguard v0.4.0 #119997

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Automated cherry pick of #119860: update to golangci-lint v1.54.1 + go-ruleguard v0.4.0 #119997

merged 1 commit into from
Sep 6, 2023

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Aug 17, 2023

Cherry pick of #119860 on release-1.27.

#119860: update to golangci-lint v1.54.1 + go-ruleguard v0.4.0

For details on the cherry pick process, see the cherry pick requests page.

@pohly
update to golangci-lint v1.54.1 + go-ruleguard v0.4.0
2898ccf 
That release is the first one with official support for Go 1.21. go-ruleguard
must be >= 0.3.20 because of
quasilyte/go-ruleguard#449 with Go
1.21. golangci-lint itself doesn't depend on a recent enough release yet, so
this was done manually.

The new ginkgolinter finds some issues in tests in the release-1.27 branch that
were fixed on master, but not backported. These issues don't need to be fixed
in a release branch, therefore the ginkgolinter gets disabled.
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Aug 17, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 17, 2023
@pohly
Copy link
Contributor Author

pohly commented Aug 17, 2023

/sig testing
/kind cleanup
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 17, 2023
@liggitt liggitt mentioned this pull request Aug 17, 2023
Closed
36 tasks
@liggitt
Copy link
Member

liggitt commented Aug 18, 2023

/lgtm
/approve
/cc @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team August 18, 2023 14:19
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c7dfbe6733fbedf8795951210e3a7a88927d6369

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2023
@liggitt liggitt added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Sep 1, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 1, 2023
xmudrii
xmudrii approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RelEng:
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pohly, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 6, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

@pohly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit-go-compatibility 2898ccf link unknown /test pull-kubernetes-unit-go-compatibility

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xmudrii
Copy link
Member

xmudrii commented Sep 6, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6769046 into kubernetes:release-1.27 Sep 6, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@xmudrii xmudrii xmudrii approved these changes

@mikedanese mikedanese Awaiting requested review from mikedanese

@thockin thockin Awaiting requested review from thockin

Assignees

@liggitt liggitt

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pohly @k8s-ci-robot @liggitt @xmudrii