eviction_manager _test.go should have unit tests that cover localStorageCapacityIsolation

[kannon92]

As I was reading the test code, I noticed that we are missing a pretty large chunk of logic around localStorageCapacityIsolation.

This feature was GA in 1.25 so it would be ideal to have unit test coverage around this code.

	// evict pods if there is a resource usage violation from local volume temporary storage
	// If eviction happens in localStorageEviction function, skip the rest of eviction action
	if m.localStorageCapacityIsolation {
		if evictedPods := m.localStorageEviction(activePods, statsFunc); len(evictedPods) > 0 {
			return evictedPods
		}
	}

This code monitors whether or not there is a violation in temporary storage and if there is it would evict the pod.

One should be able to intiailize the manager with localStorageCapacityIsolation of true and then write some test cases to verify this behavior.

/help
/sig node
/good-first-issue
/kind bug

[kannon92]

/cc @jingxu97
do you have any recollection why there weren't tests added for this path?

[charles-chenzz]

I can help with this. can you assign me after jingxu replies to you?(for more context here) @kannon92

[jingxu97]

that would be great @charles-chenzz !

[charles-chenzz]

that would be great @charles-chenzz !

you're welcome. do you have any context here that why didn't cover localStorageCapacityIsolation?

[jingxu97]

I don't recall a specific reason. The feature was implemented a while back.

[whitebeard10]

/assign

[Sajiyah-Salat]

Hey @charles-chenzz Are you still working. If not can I take this up?

[charles-chenzz]

Hey @charles-chenzz Are you still working. If not can I take this up?

@Sajiyah-Salat hi, yes I'm still working on it

[shindodkar]

@charles-chenzz hii I am new to k8s , so i wanna know can I use windows os for it? if yes would you show me how to get nodes...

[charles-chenzz]

@charles-chenzz hii I am new to k8s , so i wanna know can I use windows os for it? if yes would you show me how to get nodes...

hi, the answer is yes you can use windows and I think if you need support you better open another issue and @ me there, as this issue is not for discuss how to run k8s on windows @shindodkar

[mmiranda96]

/remove-kind bug
/kind feature
/triage accepted

[kannon92]

I see https://github.com/kubernetes/kubernetes/pull/119570/files and I am wondering if we have duplicated efforts here.

@claassen did you end up testing this path in our above PR?

[Pankaj-SinghR]

Hey, @kannon92 is someone working on this issue ? or let me know if someone need help

[sachasmart]

@kannon92 Happy to help with this. Do you still need help

[ananthmuppidi]

@kannon92 hey, is this currently still unassigned

[kannon92]

@charles-chenzz has a #120185 ready for approval.

/remove-good-first-issue
/remove-help