Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eviction manager: add test case with localStorageCapacityIsolation open #120185

Merged
merged 1 commit into from Oct 20, 2023
Merged

eviction manager: add test case with localStorageCapacityIsolation open #120185

merged 1 commit into from Oct 20, 2023

Conversation

charles-chenzz
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

this PR add test case for the missing part of manager with localStorageCapacityIsolation open and improve test coverage

Which issue(s) this PR fixes:

Fixes #120062

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 26, 2023
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 26, 2023
@charles-chenzz
Copy link
Member Author

/test all

@charles-chenzz
Copy link
Member Author

test coverage
before:
image

after:
image

kannon92
kannon92 reviewed Aug 26, 2023
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc

@charles-chenzz charles-chenzz marked this pull request as ready for review August 28, 2023 01:40
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2023
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Aug 28, 2023
kannon92
kannon92 reviewed Aug 28, 2023
View reviewed changes
pkg/kubelet/eviction/eviction_manager_test.go
func TestManagerWithLocalStorageCapacityIsolationOpen(t *testing.T) {
podMaker := makePodWithLocalStorageCapacityIsolationOpen
summaryStatsMaker := makeDiskStats
podsToMake := []podToMake{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the default case.

@bart0sh
Copy link
Contributor

bart0sh commented Aug 29, 2023

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 29, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Aug 29, 2023
@kannon92
Copy link
Contributor

LGTM to me but I am not a sig-node reviewer.

Maybe @bart0sh can review?

@rphillips
Copy link
Member

/lgtm
/assign @mrunalp

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6d137bd55f3ba89179eb58f50f487a561d8a477f

@kannon92
Copy link
Contributor

/cc @rphillips

@kannon92 kannon92 moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Sep 21, 2023
@kannon92 kannon92 mentioned this pull request Oct 1, 2023
Closed
@kannon92
Copy link
Contributor

@mrunalp or @dchen1107 could either of you take a look?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charles-chenzz, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit d916a83 into kubernetes:master Oct 20, 2023
14 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Oct 20, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 20, 2023
@charles-chenzz charles-chenzz deleted the tc_for_localstoragecapisolation branch October 21, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@mrunalp mrunalp mrunalp approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@pacoxu pacoxu Awaiting requested review from pacoxu

@krmayankk krmayankk Awaiting requested review from krmayankk

@rphillips rphillips Awaiting requested review from rphillips

Assignees

@rphillips rphillips

@mrunalp mrunalp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

eviction_manager _test.go should have unit tests that cover localStorageCapacityIsolation
6 participants
@charles-chenzz @k8s-ci-robot @bart0sh @kannon92 @rphillips @mrunalp