Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

follow up on " Merged Make Kubernetes aware of the LoadBalancer behaviour" #120068

Merged
merged 2 commits into from Aug 22, 2023
Merged

follow up on " Merged Make Kubernetes aware of the LoadBalancer behaviour" #120068

merged 2 commits into from Aug 22, 2023

Conversation

aojea
Copy link
Member

@aojea aojea commented Aug 19, 2023

/kind cleanup
/kind feature

NONE
  1. Add unit test for the kube-proxy service-cache changes to cover the new behavior when the feature flag is enabled
  2. Fix a small bug that logged the ingress IP using the ProxyMode as invalid

/sig network

@aojea
add unit test for kube-proxy service cache with ipMode
c112a34 
Change-Id: I0c25e15f259698a2882e398e05ab342bf2b38dba
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 19, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kube-proxy labels Aug 19, 2023
@aojea aojea mentioned this pull request Aug 19, 2023
Merged
@aojea
Copy link
Member Author

aojea commented Aug 19, 2023

/assign @thockin @RyanAoh

thockin
thockin reviewed Aug 19, 2023
View reviewed changes
pkg/proxy/service.go Outdated Show resolved Hide resolved
pkg/proxy/service.go Outdated Show resolved Hide resolved
@aojea aojea force-pushed the ipmode_test branch 2 times, most recently from 9a77b73 to 4198c2e Compare August 20, 2023 13:54
@aojea
kube-proxy service cache don't treat ipMode proxy address as invalid
5c7529a 
Change-Id: I4f79d4847943862dfd859325cdab075f62ef4707
thockin
thockin reviewed Aug 20, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b1456cf8f7ac6314836c62607f4eb717c8eed84b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aojea
Copy link
Member Author

aojea commented Aug 22, 2023

k8s.io/kubernetes/test/integration: scheduler expand_more

/retest

@k8s-ci-robot k8s-ci-robot merged commit aa8cb97 into kubernetes:master Aug 22, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Aug 22, 2023
@RyanAoh RyanAoh mentioned this pull request Oct 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@dcbw dcbw Awaiting requested review from dcbw

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@thockin thockin

@RyanAoh RyanAoh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kube-proxy cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aojea @k8s-ci-robot @thockin @RyanAoh