Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect tips for external cloud provider migration #120411

Closed
dims opened this issue Sep 4, 2023 · 11 comments
Closed

Collect tips for external cloud provider migration #120411

dims opened this issue Sep 4, 2023 · 11 comments
Labels
sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@dims
Copy link
Member

dims commented Sep 4, 2023

  • [kube-apiserver] ensure DisableCloudProviders is true (by default or explicitly)
  • [kubelet] ensure DisableKubeletCloudCredentialProviders is true (by default or explicitly)
  • [kubelet] Need to switch on --image-credential-provider-config and --image-credential-provider-bin-dir ( see Set external credential provider to true by default in kube-up.sh #120392 ).
  • [kube-controller-manager] Need to switch off node-ipam-controller in the value of --controllers parameter
  • Run the extra binaries/containers needed for the cloud version of the controller-manager
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 4, 2023
@dims
Copy link
Member Author

dims commented Sep 4, 2023

cc @elmiko @kmala @bridgetkromhout @aojea @andrewsykim

@sftim
Copy link
Contributor

sftim commented Sep 4, 2023

/sig cloud-provider docs

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/docs Categorizes an issue or PR as relevant to SIG Docs. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 4, 2023
@aojea
Copy link
Member

aojea commented Sep 4, 2023

  • [kube-controller-manager] Need to switch off node-ipam-controller in the value of --controllers parameter

only if uses the CloudAllocator

cmd/kube-controller-manager/app/core.go: return nil, false, errors.New("--cidr-allocator-type is set to 'CloudAllocator' but cloud provider is not configured")

@elmiko
Copy link
Contributor

elmiko commented Sep 6, 2023

thanks for starting this @dims !

@bridgetkromhout
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 7, 2023
@cpanato
Copy link
Member

cpanato commented Sep 17, 2023

I would like to know if there is any docs regarding the GCE migration, existing clusters and new ones, thanks

we will need this for capg

@elmiko
Copy link
Contributor

elmiko commented Sep 19, 2023

@cpanato i'm not finding an GCE specific docs for migration, but we do have these 2 general docs about migrating (depending on whether you are using HA or not):

we will capture the general tips for migration and troubleshooting in the KEP but for GCE specific guidance this is something that should be requested in the cloud-provider-gcp repository. i have a feeling there will be more requests like this for specific cloud provider documentation and i think we will need to focus our efforts on having the individual providers create documentation as it will not scale well to centralize this knowledge for all providers.

@elmiko
Copy link
Contributor

elmiko commented Sep 21, 2023

@dims

[kubelet] Need to switch on --image-credential-provider-config and --image-credential-provider-bin-dir

is this only for gcp?

@dims
Copy link
Member Author

dims commented Sep 21, 2023

@elmiko for all providers

@dims
Copy link
Member Author

dims commented Mar 31, 2024

/close

@k8s-ci-robot
Copy link
Contributor

@dims: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

7 participants