Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport encryption at rest automatic reload metrics bug fix #120543

Closed
enj opened this issue Sep 9, 2023 · 1 comment
Closed

Backport encryption at rest automatic reload metrics bug fix #120543

enj opened this issue Sep 9, 2023 · 1 comment
Assignees
@ritazh
Labels
sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@enj
Copy link
Member

enj commented Sep 9, 2023 

          You want all 3 metrics packages here to be safe:

	metrics.RegisterMetrics()
	storagevalue.RegisterMetrics()
	encryptionconfigmetrics.RegisterMetrics()

Also we probably need to backport this specific change (confirm that these metrics don't work on older releases before doing the backport).

Originally posted by @enj in #120438 (comment)

/assign ritazh
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 9, 2023
@enj enj mentioned this issue Sep 10, 2023
Merged
@ritazh ritazh mentioned this issue Sep 10, 2023
Merged
@enj
Copy link
Member Author

enj commented Sep 26, 2023

Fixed by #120544

@enj enj closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ritazh ritazh

Labels
sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ritazh @enj @k8s-ci-robot