Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmsv2: reload metrics bug fix backport #120544

Merged
merged 1 commit into from Sep 26, 2023
Merged

kmsv2: reload metrics bug fix backport #120544

merged 1 commit into from Sep 26, 2023

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Sep 10, 2023 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #120543

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed bug to surface events for the following metrics: apiserver_encryption_config_controller_automatic_reload_failures_total, apiserver_encryption_config_controller_automatic_reload_last_timestamp_seconds, apiserver_encryption_config_controller_automatic_reload_success_total

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@ritazh
kmsv2: reload metrics bug fix backport
2480fce 
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Sep 10, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver labels Sep 10, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 10, 2023
@ritazh
Copy link
Member Author

ritazh commented Sep 10, 2023

/triage accepted
/assign @enj

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 10, 2023
@enj
Copy link
Member

enj commented Sep 10, 2023

@ritazh I assume that you confirmed that without the init function the integration test fails? If so, I would update the release note on both this and and the other PR to describe the bug fix.

/lgtm
/approve
/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team September 10, 2023 02:10
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c129791f185c5f47d8c6a9296ebd15070250e19d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 10, 2023
@ritazh
Copy link
Member Author

ritazh commented Sep 10, 2023

@ritazh I assume that you confirmed that without the init function the integration test fails? If so, I would update the release note on both this and and the other PR to describe the bug fix.

Yes, and updated the release note for both PRs

@enj
Copy link
Member

enj commented Sep 10, 2023

No further backports are required as these metrics were added in v1.28 in #119008

cc @nilekhc

@jeremyrickard jeremyrickard added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 25, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 25, 2023
@enj
Copy link
Member

enj commented Sep 25, 2023

/retest

1 similar comment
@ritazh
Copy link
Member Author

ritazh commented Sep 26, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit de7e854 into kubernetes:release-1.28 Sep 26, 2023
16 checks passed
@enj enj mentioned this pull request Sep 26, 2023
Closed
@ritazh ritazh deleted the kmsv2-reload-bugbackport branch September 26, 2023 15:19
@sftim
Copy link
Contributor

sftim commented Oct 9, 2023

Suggestion for the changelog entry:

-Fix bug to surface events for the following metrics: apiserver_encryption_config_controller_automatic_reload_failures_total, apiserver_encryption_config_controller_automatic_reload_last_timestamp_seconds, apiserver_encryption_config_controller_automatic_reload_success_total
+Fixed bug to surface events for the following metrics: `apiserver_encryption_config_controller_automatic_reload_failures_total`, `apiserver_encryption_config_controller_automatic_reload_last_timestamp_seconds`, `apiserver_encryption_config_controller_automatic_reload_success_total`

@ritazh
Copy link
Member Author

ritazh commented Oct 9, 2023

Suggestion for the changelog entry:

-Fix bug to surface events for the following metrics: apiserver_encryption_config_controller_automatic_reload_failures_total, apiserver_encryption_config_controller_automatic_reload_last_timestamp_seconds, apiserver_encryption_config_controller_automatic_reload_success_total
+Fixed bug to surface events for the following metrics: `apiserver_encryption_config_controller_automatic_reload_failures_total`, `apiserver_encryption_config_controller_automatic_reload_last_timestamp_seconds`, `apiserver_encryption_config_controller_automatic_reload_success_total`

Thanks Tim! Updated release note section above.

@pacoxu pacoxu mentioned this pull request Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Auth: KMS v2
Status: ✅ Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ritazh @enj @k8s-ci-robot @sftim @jeremyrickard