Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #119825: Move adding GroupVersion log until after an update is #122074

Merged
merged 1 commit into from Nov 29, 2023
Merged

Automated cherry pick of #119825: Move adding GroupVersion log until after an update is #122074

merged 1 commit into from Nov 29, 2023

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Nov 27, 2023 •
edited by liggitt

Cherry pick of #119825 on release-1.27.

#119825: Move adding GroupVersion log until after an update is

For details on the cherry pick process, see the cherry pick requests page.

Fixes a kube-apiserver log volume regression bug in default 1.27 configurations (introduced in 1.26, activated by the AggregatedDiscoveryEndpoint feature enablement in 1.27)

Requesting cherry pick due to log volume regression xref: #119546 the code was introduced as 6e83f67 in 1.26 but the AggregatedDiscoveryEndpoint feature was enabled by default in 1.27 causing the huge amount of logs to be generated by default.

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Nov 27, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 27, 2023
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 27, 2023
@ritazh
Copy link
Member Author

ritazh commented Nov 27, 2023

cc @liggitt @jeremyrickard

@liggitt
Copy link
Member

liggitt commented Nov 27, 2023

can you add a release note describing the issue this is fixing and the version the problem was introduced in, and updating the PR description with details about why this is a big enough problem to backport

@liggitt
Copy link
Member

liggitt commented Nov 27, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9fd7619738574828c9df39aeda304c85c0e6bca6

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 27, 2023
@ritazh
Copy link
Member Author

ritazh commented Nov 27, 2023

can you add a release note describing the issue this is fixing and the version the problem was introduced in, and updating the PR description with details about why this is a big enough problem to backport

done

@ritazh
Copy link
Member Author

ritazh commented Nov 28, 2023

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team November 28, 2023 18:53
@jiahuif
Copy link
Member

jiahuif commented Nov 28, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 28, 2023
@ritazh
Copy link
Member Author

ritazh commented Nov 28, 2023

xref: #122096

@liggitt
Copy link
Member

liggitt commented Nov 28, 2023

should also be picked to 1.26 if that's when it regressed, right?

@liggitt
Copy link
Member

liggitt commented Nov 28, 2023

oh, misread that the feature gate enablement was also required, which defaulted in 1.27

@liggitt
Copy link
Member

liggitt commented Nov 28, 2023

/kind bug
/kind regression

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 28, 2023
xmudrii
xmudrii approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RelEng:
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, ritazh, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 29, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 80862e1 into kubernetes:release-1.27 Nov 29, 2023
14 checks passed
@ritazh ritazh deleted the automated-cherry-pick-of-#119825-upstream-release-1.27 branch November 29, 2023 17:25
@liggitt liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@alexzielenski alexzielenski Awaiting requested review from alexzielenski

@Jefftree Jefftree Awaiting requested review from Jefftree

Assignees

@liggitt liggitt

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ritazh @liggitt @k8s-ci-robot @jiahuif @xmudrii @Jefftree