Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move adding GroupVersion log until after an update is confirmed #119825

Merged
merged 1 commit into from Aug 16, 2023

Conversation

Jefftree
Copy link
Member

@Jefftree Jefftree commented Aug 8, 2023

/kind cleanup

What this PR does / why we need it:

Move add GroupVersion log until after an update is confirmed. If the discovery document is unchanged, do not log to prevent polluting the log files. We could technically divide this further into "adding...", "updating...", etc.

Which issue(s) this PR fixes:

Fixes #119546

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes bug where Adding GroupVersion log line is constantly repeated without any group version changes

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/cc @hickersonj @apelisse @alexzielenski

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 8, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

@Jefftree: GitHub didn't allow me to request PR reviews from the following users: hickersonj.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/kind cleanup

What this PR does / why we need it:

Move add GroupVersion log until after an update is confirmed. If the discovery document is unchanged, do not log to prevent polluting the log files. We could technically divide this further into "adding...", "updating...", etc.

Which issue(s) this PR fixes:

Fixes #119546

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes bug where Adding GroupVersion log line is constantly repeated without any group version changes

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/cc @hickersonj @apelisse @alexzielenski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.28 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.28.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 8, 2023
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 8, 2023
@Jefftree
Copy link
Member Author

Jefftree commented Aug 8, 2023

/retest

@alexzielenski
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 8, 2023
@apelisse
Copy link
Member

apelisse commented Aug 8, 2023

I think that's fine, thanks
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dff19352ab683e05c970df0a8b034af5d0e71389

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, Jefftree

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@mengjiao-liu
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 47f7570 into kubernetes:master Aug 16, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Aug 16, 2023
k8s-ci-robot added a commit that referenced this pull request Nov 29, 2023
…25-upstream-release-1.27

Automated cherry pick of #119825: Move adding GroupVersion log until after an update is
k8s-ci-robot added a commit that referenced this pull request Nov 29, 2023
…25-upstream-release-1.28

Automated cherry pick of #119825: Move adding GroupVersion log until after an update is
@Jefftree Jefftree deleted the add-gv branch January 25, 2024 22:22
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After upgrading to version v1.27.3 Adding GroupVersion is repeated in the api-server log
6 participants