New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move adding GroupVersion log until after an update is confirmed #119825
Conversation
@Jefftree: GitHub didn't allow me to request PR reviews from the following users: hickersonj. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023. |
/retest |
/triage accepted |
I think that's fine, thanks |
LGTM label has been added. Git tree hash: dff19352ab683e05c970df0a8b034af5d0e71389
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, Jefftree The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
…25-upstream-release-1.27 Automated cherry pick of #119825: Move adding GroupVersion log until after an update is
…25-upstream-release-1.28 Automated cherry pick of #119825: Move adding GroupVersion log until after an update is
/kind cleanup
What this PR does / why we need it:
Move add GroupVersion log until after an update is confirmed. If the discovery document is unchanged, do not log to prevent polluting the log files. We could technically divide this further into "adding...", "updating...", etc.
Which issue(s) this PR fixes:
Fixes #119546
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @hickersonj @apelisse @alexzielenski