why encode object instead of event and returned directly in watchEncoder?

[likakuli]

What happened?

https://github.com/kubernetes/kubernetes/pull/120300/files#diff-12e0758457373aa860bb0baae0878a99c107840d25fcf356d126d4b3d1d15663R177-R178

Encode function of watchEncoder write event serialization result to response. the above lines seems only write object instead of event to response. not sure if my understanding is correct.

What did you expect to happen?

write event to response

How can we reproduce it (as minimally and precisely as possible)?

add a unit test and set object in event to CacheableObject

Anything else we need to know?

No response

Kubernetes version

$ kubectl version
# paste output here

Cloud provider

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

[k8s-ci-robot]

@likakuli: The label(s) sig/apiserver cannot be applied, because the repository doesn't have them.

In response to this:

/sig apiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[likakuli]

/sig api-machinery

[liggitt]

@wojtek-t could probably answer this

[wojtek-t]

https://github.com/kubernetes/kubernetes/pull/120300/files#diff-12e0758457373aa860bb0baae0878a99c107840d25fcf356d126d4b3d1d15663R177-R178

Encode function of watchEncoder write event serialization result to response. the above lines seems only write object instead of event to response. not sure if my understanding is correct.

That is not correct - this works as it should.
You can take a look at #120300 for the implementation.

Basically, we store also encoding of the "whole watch event" inside the CachingObject cache to avoid serializing them independently. You can see that the identifier contains the watch event type so that each even would be serialized independently.
Appropriate tests were added in that PR too.

[likakuli]

I misunderstood the code previously, but now it seems fine. Thank you

[alexzielenski]

/triage accepted