Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-controller-manager: unit tests WatchListClient feature for client-go #122608

Merged
merged 1 commit into from Jan 18, 2024
Merged

kube-controller-manager: unit tests WatchListClient feature for client-go #122608

merged 1 commit into from Jan 18, 2024

Conversation

p0lyn0mial
Copy link
Contributor

@p0lyn0mial p0lyn0mial commented Jan 5, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Tests whether the WatchListClient (defined in client-go) is exposed as a command line option for KCM with its default value set to false.

We specificity test for KCM because this will be the only component using the watch-list feature for this release (targeted for 1.30).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

requires:

xref: kubernetes/enhancements#3157

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/3157-watch-list/README.md
- [Other doc]: https://docs.google.com/document/d/1g9BGCRw-7ucUxO6OtCWbb3lfzUGA_uU9178wLdXAIfs/edit#heading=h.lymszxjovg65

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 5, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial p0lyn0mial force-pushed the upstream-kcm-enable-watchlistclient-fg branch from a034fd2 to f0298b3 Compare January 15, 2024 10:29
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 15, 2024
@p0lyn0mial p0lyn0mial force-pushed the upstream-kcm-enable-watchlistclient-fg branch from f0298b3 to d478c15 Compare January 15, 2024 11:57
@p0lyn0mial p0lyn0mial mentioned this pull request Jan 15, 2024
Merged
@p0lyn0mial p0lyn0mial force-pushed the upstream-kcm-enable-watchlistclient-fg branch from d478c15 to 5d3fdc9 Compare January 16, 2024 08:27
@p0lyn0mial p0lyn0mial changed the title [WIP]: kube-controller-manager: enable WatchListClient feature for client-go [WIP]: kube-controller-manager: unit tests WatchListClient feature for client-go Jan 16, 2024
@deads2k
Copy link
Contributor

deads2k commented Jan 16, 2024

Just additional tests for #122738 ? No objection, but next time you could get Ben to include them.

@p0lyn0mial p0lyn0mial force-pushed the upstream-kcm-enable-watchlistclient-fg branch from 5d3fdc9 to 8668c7f Compare January 18, 2024 08:23
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2024
@p0lyn0mial p0lyn0mial changed the title [WIP]: kube-controller-manager: unit tests WatchListClient feature for client-go kube-controller-manager: unit tests WatchListClient feature for client-go Jan 18, 2024
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 18, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 18, 2024
@p0lyn0mial
Copy link
Contributor Author

Just additional tests for #122738 ? No objection, but next time you could get Ben to include them.

Yes, just additional tests, no problem. Although, I prefer to open smaller PRs for easier review.

@p0lyn0mial
Copy link
Contributor Author

/assign @deads2k @soltysh

cc @wojtek-t

soltysh
soltysh approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a22d4a605396d5048626cbd8f8e96e9c1f4c680e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@soltysh
Copy link
Contributor

soltysh commented Jan 18, 2024

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit b1ab18a into kubernetes:master Jan 18, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@dims dims Awaiting requested review from dims

Assignees

@soltysh soltysh

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@p0lyn0mial @k8s-ci-robot @deads2k @soltysh