Assigned Pod add/update events don't requeue Pods without PodAffinity

[sanposhiho]

What happened?

/sig scheduling
/kind bug

• AssignedPodAdded():

  kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go

  Line 1044 in b529e6f

  p.movePodsToActiveOrBackoffQueue(logger, p.getUnschedulablePodsWithMatchingAffinityTerm(logger, pod), AssignedPodAdd, nil, pod)

• AssignedPodUpdated():

  kubernetes/pkg/scheduler/internal/queue/scheduling_queue.go

  Line 1069 in b529e6f

  p.movePodsToActiveOrBackoffQueue(logger, p.getUnschedulablePodsWithMatchingAffinityTerm(logger, newPod), AssignedPodUpdate, oldPod, newPod)

When assigned Pods are created/updated, cluster events (Pod/Add or Pod/Update) should be delivered for all plugins that subscribe those events. But, actually getUnschedulablePodsWithMatchingAffinityTerm pre-filters Pods to receive those events based on Pods' affinity and pod.Status.Resize. - meaning only PodAffinity/NodeResourceFit receive them actually.

The problem here is similar to #110175 - in in-tree plugins, PodAffinity, PodTopologySpread and NodeResourceFit subscribe Pod add and/or update events. And, Pods rejected by PodTopologySpread will never be requeued to activeQ by Pod-related events. The same happens for custom plugins registering pod add and/or update events.

What did you expect to happen?

All Pods will get chances to get back to activeQ by Pod-related events.

How can we reproduce it (as minimally and precisely as possible)?

Run ↓ in https://github.com/sanposhiho/kubernetes/tree/pod-bug-repro.

 make test-integration WHAT=./test/integration/scheduler KUBE_TEST_ARGS="-run=^TestCoreResourceEnqueue$" 

Anything else we need to know?

No response

Kubernetes version

master

Cloud provider

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sanposhiho]

/assign

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[sanposhiho]

/remove-lifecycle stale