Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobs should display whether or not they are suspended. #123221

Closed
kannon92 opened this issue Feb 9, 2024 · 9 comments · Fixed by #123226
Closed

Jobs should display whether or not they are suspended. #123221

kannon92 opened this issue Feb 9, 2024 · 9 comments · Fixed by #123226
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/batch Categorizes an issue or PR as relevant to WG Batch.

Comments

@kannon92
Copy link
Contributor

kannon92 commented Feb 9, 2024

What would you like to be added?

Suspend is a GA feature and it is big component of Kueue.

It would be nice to display if jobs are suspended when doing kubectl get job.

kehannon@kehannon-thinkpadp1gen4i:~/Work/jobset/examples/startup-policy$ kubectl get jobs
NAME                                        COMPLETIONS   DURATION   AGE
pytorch-job                                 0/4           8d         8d
pytorch-workers-0                           1/4           8d         8d
success-policy-workers-0                    2/2           14s        8d
suspend-startup-driver-anyorder-driver-0    0/1                      10s
suspend-startup-driver-anyorder-workers-0   0/4                      10s
suspend-startup-driver-ready-driver-0       0/1                      49s
suspend-startup-driver-ready-workers-0      0/4                      49s

A new column that displays if the job is suspended would be helpful.

Why is this needed?

Improve UX around suspend. Its a bit difficult to know why the job has not created pods unless you know about the suspend field.

@kannon92 kannon92 added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 9, 2024
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 9, 2024
@kannon92
Copy link
Contributor Author

kannon92 commented Feb 9, 2024

/sig cli
/wg batch
/good-first-issue
/help-wanted

@k8s-ci-robot
Copy link
Contributor

@kannon92:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/sig cli
/wg batch
/good-first-issue
/help-wanted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. wg/batch Categorizes an issue or PR as relevant to WG Batch. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 9, 2024
@kannon92
Copy link
Contributor Author

kannon92 commented Feb 9, 2024

/cc @alculquicondor @mimowo

Just something I noticed as I was testing some job in JobSet. It would be nice to see which jobs are suspended when doing kubectl get job. Hope its not a controversial change.

@mimowo
Copy link
Contributor

mimowo commented Feb 9, 2024

cc @ivanvc who worked on #122618

@alculquicondor
Copy link
Member

Not controversial at all IMO

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 9, 2024
@ivanvc
Copy link
Contributor

ivanvc commented Feb 9, 2024

/assign

@ivanvc
Copy link
Contributor

ivanvc commented Feb 9, 2024

Any suggestions on where to place this column? I'm thinking between completions and durations. Or, should this be displayed only when the output is set to wide?

@alculquicondor
Copy link
Member

I would put it in the default view as well. Probably before completions

@ivanvc
Copy link
Contributor

ivanvc commented Feb 9, 2024

Addressed in the PR: #123226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/batch Categorizes an issue or PR as relevant to WG Batch.
Projects
Archived in project
5 participants